Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ai_services): raise exception if api_key None or empty #1195

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Vaibhav159
Copy link
Contributor

@Vaibhav159 Vaibhav159 commented Feb 10, 2025

  1. having api_key check in services where it is required
  2. Using self._api_key as a single source of control
  3. Custom pipecat exceptions to better error handling

@Vaibhav159
Copy link
Contributor Author

@aconchillo @markbackman this is up for review, but want to get your thoughts on one thing, i feel setting self._api_key in each service is a bit overkill, since we can put it in core base classes like LLMService/ TTSService and once init is done, can safely refer the same at all places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants