-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix transcripts in translation chatbot example #1199
base: main
Are you sure you want to change the base?
Conversation
ec31f9c
to
79199e6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
@@ -1,4 +1,4 @@ | |||
python-dotenv | |||
fastapi[all] | |||
pipecat-ai[daily,openai,azure] | |||
pipecat-ai[audio,cartesia,daily,deepgram,google,openai,silero] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deleted my venv and started again and noticed a few of these were missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like audio
and google
are unused here. Let's remove them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markbackman it looks like RTVI accidentally depends on google
because a dependency of rtvi is importing a google class definition 🤔
2025-02-14 09:01:45.056 | ERROR | pipecat.services.google.google:<module>:59 - Exception: No module named 'google.ai'
2025-02-14 09:01:45.056 | ERROR | pipecat.services.google.google:<module>:60 - In order to use Google AI, you need to `pip install pipecat-ai[google]`. Also, set the environment variable GOOGLE_API_KEY for the GoogleLLMService and GOOGLE_APPLICATION_CREDENTIALS for the GoogleTTSService`.
Traceback (most recent call last):
File "/Users/jamsea/git/pipecat/examples/translation-chatbot/.venv/lib/python3.13/site-packages/pipecat/services/google/google.py", line 51, in <module>
import google.ai.generativelanguage as glm
ModuleNotFoundError: No module named 'google.ai'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<frozen runpy>", line 198, in _run_module_as_main
File "<frozen runpy>", line 88, in _run_code
File "/Users/jamsea/git/pipecat/examples/translation-chatbot/bot.py", line 30, in <module>
from pipecat.processors.frameworks.rtvi import (
...<3 lines>...
)
File "/Users/jamsea/git/pipecat/examples/translation-chatbot/.venv/lib/python3.13/site-packages/pipecat/processors/frameworks/rtvi.py", line 61, in <module>
from pipecat.services.google.frames import LLMSearchOrigin, LLMSearchResponseFrame
File "/Users/jamsea/git/pipecat/examples/translation-chatbot/.venv/lib/python3.13/site-packages/pipecat/services/google/__init__.py", line 2, in <module>
from .google import *
File "/Users/jamsea/git/pipecat/examples/translation-chatbot/.venv/lib/python3.13/site-packages/pipecat/services/google/google.py", line 63, in <module>
raise Exception(f"Missing module: {e}")
Exception: Missing module: No module named 'google.ai'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @filipi87 does that ring a bell?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two classes, LLMSearchOrigin
and LLMSearchResponseFrame
, are the ones that we have created for the Google Search response, and are inside the Google. But they should be needed only when using the GoogleRTVIObserver
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I have just tested, and if use the version from main
, it works as expected. This are all the dependencies that we need.
pip install -e "../..[silero, cartesia, daily, openai, deepgram]"
We have released a version where the RTVI was depending on Google, but that has been fixed by Aleix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Yes, in Pipecat 0.0.57, that dependency will be removed. We're releasing 0.0.57 today; we can update this PR to remove the google
dependency then.
Please describe the changes in your PR. If it is addressing an issue, please reference that as well.