Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing google llm service error #1212

Merged
merged 1 commit into from
Feb 14, 2025
Merged

fixing google llm service error #1212

merged 1 commit into from
Feb 14, 2025
+7 −3

Conversation

Vaibhav159
Copy link
Contributor

Fixed an issue where has_regular_messages condition was always been true in GoogleLLMContext due to Part having function_call & function_response with None values.

image

@Vaibhav159
Copy link
Contributor Author

@aconchillo @markbackman Minor bug fix in google llm service.

@codecov Codecov
Copy link

codecov bot commented Feb 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pipecat/services/google/google.py 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/pipecat/services/google/google.py 0.00% <0.00%> (ø)

... and 10 files with indirect coverage changes

@aconchillo
Copy link
Contributor

Thank you! LGTM!

@aconchillo aconchillo merged commit b3a575c into pipecat-ai:main Feb 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aconchillo aconchillo aconchillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vaibhav159 @aconchillo