Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instant voice example. #1220

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Instant voice example. #1220

merged 1 commit into from
Feb 14, 2025
+2,815 −0

Conversation

filipi87
Copy link
Contributor

Instant voice demo example.

@codecov Codecov
Copy link

codecov bot commented Feb 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

see 25 files with indirect coverage changes

@filipi87 filipi87 marked this pull request as ready for review February 13, 2025 22:08
@filipi87 filipi87 force-pushed the instant_voice_demo_example branch from 2ea8a37 to 63fc6c7 Compare February 13, 2025 22:12
markbackman
markbackman approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@markbackman markbackman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great! The connection does feel fast! ⚡

Suggestion: we should change the demo's name. How about instant-voice-connection?

@filipi87 filipi87 force-pushed the instant_voice_demo_example branch from 63fc6c7 to bff5454 Compare February 14, 2025 17:19
@filipi87 filipi87 changed the title Instant voice demo example. Instant voice example. Feb 14, 2025
@filipi87 filipi87 merged commit 8588f8b into main Feb 14, 2025
6 checks passed
@filipi87 filipi87 deleted the instant_voice_demo_example branch February 14, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markbackman markbackman markbackman approved these changes

@aconchillo aconchillo Awaiting requested review from aconchillo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipi87 @markbackman