Skip to content

Conversation

@pull
Copy link

@pull pull bot commented Feb 3, 2026

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

serge-sans-paille and others added 30 commits February 2, 2026 17:56
…come before compiler is defined r=glandium

This is defined so that compiler checks can use SDK informations.
It also makes toolchain.configure more readable.

Differential Revision: https://phabricator.services.mozilla.com/D278616
…glandium

As suggested in the documentation, see https://github.com/microsoft/STL/wiki/Macro-_MSVC_STL_UPDATE

And the ehader is present on older STL/libcxx version too.

Differential Revision: https://phabricator.services.mozilla.com/D278617
… bandwidth. r=ip-protection-reviewers,fluent-reviewers,rking,bolsson

Differential Revision: https://phabricator.services.mozilla.com/D280438
In bug 1973333, we moved the AutoCheckRecursionLimit lower in InnerModuleLinking, apparently so that we would maintain invariants if we threw and then recovered. I considered trying the same thing here, but wasn't sure where a better place might be. There's an existing OOM failure path immediately following this check, so if throwing an error here can leave us in a bad state, it's already a problem independent of this patch.

Differential Revision: https://phabricator.services.mozilla.com/D281302
… info r=glandium" for causing build bustages.

This reverts commit 7135d51.

This reverts commit c5cd2cc.
…" for causing linting opt failures.

This reverts commit 1714552.
…ILD CLOSED TREE

ach -> 0b7b03b20acb540d1b06110667359ae61ab17849
af -> 0b7b03b20acb540d1b06110667359ae61ab17849
an -> 0b7b03b20acb540d1b06110667359ae61ab17849
ar -> 0b7b03b20acb540d1b06110667359ae61ab17849
ast -> 0b7b03b20acb540d1b06110667359ae61ab17849
az -> 0b7b03b20acb540d1b06110667359ae61ab17849
be -> 0b7b03b20acb540d1b06110667359ae61ab17849
bg -> 0b7b03b20acb540d1b06110667359ae61ab17849
bn -> 0b7b03b20acb540d1b06110667359ae61ab17849
bo -> 0b7b03b20acb540d1b06110667359ae61ab17849
br -> 0b7b03b20acb540d1b06110667359ae61ab17849
brx -> 0b7b03b20acb540d1b06110667359ae61ab17849
bs -> 0b7b03b20acb540d1b06110667359ae61ab17849
ca -> 0b7b03b20acb540d1b06110667359ae61ab17849
ca-valencia -> 0b7b03b20acb540d1b06110667359ae61ab17849
cak -> 0b7b03b20acb540d1b06110667359ae61ab17849
ckb -> 0b7b03b20acb540d1b06110667359ae61ab17849
cs -> 0b7b03b20acb540d1b06110667359ae61ab17849
cy -> 0b7b03b20acb540d1b06110667359ae61ab17849
da -> 0b7b03b20acb540d1b06110667359ae61ab17849
de -> 0b7b03b20acb540d1b06110667359ae61ab17849
dsb -> 0b7b03b20acb540d1b06110667359ae61ab17849
el -> 0b7b03b20acb540d1b06110667359ae61ab17849
en-CA -> 0b7b03b20acb540d1b06110667359ae61ab17849
en-GB -> 0b7b03b20acb540d1b06110667359ae61ab17849
eo -> 0b7b03b20acb540d1b06110667359ae61ab17849
es-AR -> 0b7b03b20acb540d1b06110667359ae61ab17849
es-CL -> 0b7b03b20acb540d1b06110667359ae61ab17849
es-ES -> 0b7b03b20acb540d1b06110667359ae61ab17849
es-MX -> 0b7b03b20acb540d1b06110667359ae61ab17849
et -> 0b7b03b20acb540d1b06110667359ae61ab17849
eu -> 0b7b03b20acb540d1b06110667359ae61ab17849
fa -> 0b7b03b20acb540d1b06110667359ae61ab17849
ff -> 0b7b03b20acb540d1b06110667359ae61ab17849
fi -> 0b7b03b20acb540d1b06110667359ae61ab17849
fr -> 0b7b03b20acb540d1b06110667359ae61ab17849
fur -> 0b7b03b20acb540d1b06110667359ae61ab17849
fy-NL -> 0b7b03b20acb540d1b06110667359ae61ab17849
ga-IE -> 0b7b03b20acb540d1b06110667359ae61ab17849
gd -> 0b7b03b20acb540d1b06110667359ae61ab17849
gl -> 0b7b03b20acb540d1b06110667359ae61ab17849
gn -> 0b7b03b20acb540d1b06110667359ae61ab17849
gu-IN -> 0b7b03b20acb540d1b06110667359ae61ab17849
he -> 0b7b03b20acb540d1b06110667359ae61ab17849
hi-IN -> 0b7b03b20acb540d1b06110667359ae61ab17849
hr -> 0b7b03b20acb540d1b06110667359ae61ab17849
hsb -> 0b7b03b20acb540d1b06110667359ae61ab17849
hu -> 0b7b03b20acb540d1b06110667359ae61ab17849
hy-AM -> 0b7b03b20acb540d1b06110667359ae61ab17849
hye -> 0b7b03b20acb540d1b06110667359ae61ab17849
ia -> 0b7b03b20acb540d1b06110667359ae61ab17849
id -> 0b7b03b20acb540d1b06110667359ae61ab17849
is -> 0b7b03b20acb540d1b06110667359ae61ab17849
it -> 0b7b03b20acb540d1b06110667359ae61ab17849
ja -> 0b7b03b20acb540d1b06110667359ae61ab17849
ja-JP-mac -> 0b7b03b20acb540d1b06110667359ae61ab17849
ka -> 0b7b03b20acb540d1b06110667359ae61ab17849
kab -> 0b7b03b20acb540d1b06110667359ae61ab17849
kk -> 0b7b03b20acb540d1b06110667359ae61ab17849
km -> 0b7b03b20acb540d1b06110667359ae61ab17849
kn -> 0b7b03b20acb540d1b06110667359ae61ab17849
ko -> 0b7b03b20acb540d1b06110667359ae61ab17849
lij -> 0b7b03b20acb540d1b06110667359ae61ab17849
lo -> 0b7b03b20acb540d1b06110667359ae61ab17849
lt -> 0b7b03b20acb540d1b06110667359ae61ab17849
ltg -> 0b7b03b20acb540d1b06110667359ae61ab17849
lv -> 0b7b03b20acb540d1b06110667359ae61ab17849
meh -> 0b7b03b20acb540d1b06110667359ae61ab17849
mk -> 0b7b03b20acb540d1b06110667359ae61ab17849
ml -> 0b7b03b20acb540d1b06110667359ae61ab17849
mr -> 0b7b03b20acb540d1b06110667359ae61ab17849
ms -> 0b7b03b20acb540d1b06110667359ae61ab17849
my -> 0b7b03b20acb540d1b06110667359ae61ab17849
nb-NO -> 0b7b03b20acb540d1b06110667359ae61ab17849
ne-NP -> 0b7b03b20acb540d1b06110667359ae61ab17849
nl -> 0b7b03b20acb540d1b06110667359ae61ab17849
nn-NO -> 0b7b03b20acb540d1b06110667359ae61ab17849
oc -> 0b7b03b20acb540d1b06110667359ae61ab17849
pa-IN -> 0b7b03b20acb540d1b06110667359ae61ab17849
pl -> 0b7b03b20acb540d1b06110667359ae61ab17849
pt-BR -> 0b7b03b20acb540d1b06110667359ae61ab17849
pt-PT -> 0b7b03b20acb540d1b06110667359ae61ab17849
rm -> 0b7b03b20acb540d1b06110667359ae61ab17849
ro -> 0b7b03b20acb540d1b06110667359ae61ab17849
ru -> 0b7b03b20acb540d1b06110667359ae61ab17849
sat -> 0b7b03b20acb540d1b06110667359ae61ab17849
sc -> 0b7b03b20acb540d1b06110667359ae61ab17849
scn -> 0b7b03b20acb540d1b06110667359ae61ab17849
sco -> 0b7b03b20acb540d1b06110667359ae61ab17849
si -> 0b7b03b20acb540d1b06110667359ae61ab17849
sk -> 0b7b03b20acb540d1b06110667359ae61ab17849
skr -> 0b7b03b20acb540d1b06110667359ae61ab17849
sl -> 0b7b03b20acb540d1b06110667359ae61ab17849
son -> 0b7b03b20acb540d1b06110667359ae61ab17849
sq -> 0b7b03b20acb540d1b06110667359ae61ab17849
sr -> 0b7b03b20acb540d1b06110667359ae61ab17849
sv-SE -> 0b7b03b20acb540d1b06110667359ae61ab17849
szl -> 0b7b03b20acb540d1b06110667359ae61ab17849
ta -> 0b7b03b20acb540d1b06110667359ae61ab17849
te -> 0b7b03b20acb540d1b06110667359ae61ab17849
tg -> 0b7b03b20acb540d1b06110667359ae61ab17849
th -> 0b7b03b20acb540d1b06110667359ae61ab17849
tl -> 0b7b03b20acb540d1b06110667359ae61ab17849
tr -> 0b7b03b20acb540d1b06110667359ae61ab17849
trs -> 0b7b03b20acb540d1b06110667359ae61ab17849
uk -> 0b7b03b20acb540d1b06110667359ae61ab17849
ur -> 0b7b03b20acb540d1b06110667359ae61ab17849
uz -> 0b7b03b20acb540d1b06110667359ae61ab17849
vi -> 0b7b03b20acb540d1b06110667359ae61ab17849
wo -> 0b7b03b20acb540d1b06110667359ae61ab17849
xh -> 0b7b03b20acb540d1b06110667359ae61ab17849
zh-CN -> 0b7b03b20acb540d1b06110667359ae61ab17849
zh-TW -> 0b7b03b20acb540d1b06110667359ae61ab17849
…LD CLOSED TREE

ach -> 0b7b03b20acb540d1b06110667359ae61ab17849
an -> 0b7b03b20acb540d1b06110667359ae61ab17849
ar -> 0b7b03b20acb540d1b06110667359ae61ab17849
ast -> 0b7b03b20acb540d1b06110667359ae61ab17849
az -> 0b7b03b20acb540d1b06110667359ae61ab17849
be -> 0b7b03b20acb540d1b06110667359ae61ab17849
bg -> 0b7b03b20acb540d1b06110667359ae61ab17849
bn -> 0b7b03b20acb540d1b06110667359ae61ab17849
br -> 0b7b03b20acb540d1b06110667359ae61ab17849
bs -> 0b7b03b20acb540d1b06110667359ae61ab17849
ca -> 0b7b03b20acb540d1b06110667359ae61ab17849
cak -> 0b7b03b20acb540d1b06110667359ae61ab17849
cs -> 0b7b03b20acb540d1b06110667359ae61ab17849
cy -> 0b7b03b20acb540d1b06110667359ae61ab17849
da -> 0b7b03b20acb540d1b06110667359ae61ab17849
de -> 0b7b03b20acb540d1b06110667359ae61ab17849
dsb -> 0b7b03b20acb540d1b06110667359ae61ab17849
el -> 0b7b03b20acb540d1b06110667359ae61ab17849
en-CA -> 0b7b03b20acb540d1b06110667359ae61ab17849
en-GB -> 0b7b03b20acb540d1b06110667359ae61ab17849
eo -> 0b7b03b20acb540d1b06110667359ae61ab17849
es-AR -> 0b7b03b20acb540d1b06110667359ae61ab17849
es-CL -> 0b7b03b20acb540d1b06110667359ae61ab17849
es-ES -> 0b7b03b20acb540d1b06110667359ae61ab17849
es-MX -> 0b7b03b20acb540d1b06110667359ae61ab17849
et -> 0b7b03b20acb540d1b06110667359ae61ab17849
eu -> 0b7b03b20acb540d1b06110667359ae61ab17849
fa -> 0b7b03b20acb540d1b06110667359ae61ab17849
ff -> 0b7b03b20acb540d1b06110667359ae61ab17849
fi -> 0b7b03b20acb540d1b06110667359ae61ab17849
fr -> 0b7b03b20acb540d1b06110667359ae61ab17849
fy-NL -> 0b7b03b20acb540d1b06110667359ae61ab17849
ga-IE -> 0b7b03b20acb540d1b06110667359ae61ab17849
gd -> 0b7b03b20acb540d1b06110667359ae61ab17849
gl -> 0b7b03b20acb540d1b06110667359ae61ab17849
gn -> 0b7b03b20acb540d1b06110667359ae61ab17849
gu-IN -> 0b7b03b20acb540d1b06110667359ae61ab17849
he -> 0b7b03b20acb540d1b06110667359ae61ab17849
hi-IN -> 0b7b03b20acb540d1b06110667359ae61ab17849
hr -> 0b7b03b20acb540d1b06110667359ae61ab17849
hsb -> 0b7b03b20acb540d1b06110667359ae61ab17849
hu -> 0b7b03b20acb540d1b06110667359ae61ab17849
hy-AM -> 0b7b03b20acb540d1b06110667359ae61ab17849
ia -> 0b7b03b20acb540d1b06110667359ae61ab17849
id -> 0b7b03b20acb540d1b06110667359ae61ab17849
is -> 0b7b03b20acb540d1b06110667359ae61ab17849
it -> 0b7b03b20acb540d1b06110667359ae61ab17849
ja -> 0b7b03b20acb540d1b06110667359ae61ab17849
ka -> 0b7b03b20acb540d1b06110667359ae61ab17849
kab -> 0b7b03b20acb540d1b06110667359ae61ab17849
kk -> 0b7b03b20acb540d1b06110667359ae61ab17849
km -> 0b7b03b20acb540d1b06110667359ae61ab17849
kn -> 0b7b03b20acb540d1b06110667359ae61ab17849
ko -> 0b7b03b20acb540d1b06110667359ae61ab17849
lij -> 0b7b03b20acb540d1b06110667359ae61ab17849
lo -> 0b7b03b20acb540d1b06110667359ae61ab17849
lt -> 0b7b03b20acb540d1b06110667359ae61ab17849
ltg -> 0b7b03b20acb540d1b06110667359ae61ab17849
lv -> 0b7b03b20acb540d1b06110667359ae61ab17849
meh -> 0b7b03b20acb540d1b06110667359ae61ab17849
mix -> 0b7b03b20acb540d1b06110667359ae61ab17849
ml -> 0b7b03b20acb540d1b06110667359ae61ab17849
mr -> 0b7b03b20acb540d1b06110667359ae61ab17849
ms -> 0b7b03b20acb540d1b06110667359ae61ab17849
my -> 0b7b03b20acb540d1b06110667359ae61ab17849
nb-NO -> 0b7b03b20acb540d1b06110667359ae61ab17849
ne-NP -> 0b7b03b20acb540d1b06110667359ae61ab17849
nl -> 0b7b03b20acb540d1b06110667359ae61ab17849
nn-NO -> 0b7b03b20acb540d1b06110667359ae61ab17849
oc -> 0b7b03b20acb540d1b06110667359ae61ab17849
pa-IN -> 0b7b03b20acb540d1b06110667359ae61ab17849
pl -> 0b7b03b20acb540d1b06110667359ae61ab17849
pt-BR -> 0b7b03b20acb540d1b06110667359ae61ab17849
pt-PT -> 0b7b03b20acb540d1b06110667359ae61ab17849
rm -> 0b7b03b20acb540d1b06110667359ae61ab17849
ro -> 0b7b03b20acb540d1b06110667359ae61ab17849
ru -> 0b7b03b20acb540d1b06110667359ae61ab17849
sk -> 0b7b03b20acb540d1b06110667359ae61ab17849
sl -> 0b7b03b20acb540d1b06110667359ae61ab17849
son -> 0b7b03b20acb540d1b06110667359ae61ab17849
sq -> 0b7b03b20acb540d1b06110667359ae61ab17849
sr -> 0b7b03b20acb540d1b06110667359ae61ab17849
sv-SE -> 0b7b03b20acb540d1b06110667359ae61ab17849
ta -> 0b7b03b20acb540d1b06110667359ae61ab17849
te -> 0b7b03b20acb540d1b06110667359ae61ab17849
th -> 0b7b03b20acb540d1b06110667359ae61ab17849
tl -> 0b7b03b20acb540d1b06110667359ae61ab17849
tr -> 0b7b03b20acb540d1b06110667359ae61ab17849
trs -> 0b7b03b20acb540d1b06110667359ae61ab17849
uk -> 0b7b03b20acb540d1b06110667359ae61ab17849
ur -> 0b7b03b20acb540d1b06110667359ae61ab17849
uz -> 0b7b03b20acb540d1b06110667359ae61ab17849
vi -> 0b7b03b20acb540d1b06110667359ae61ab17849
wo -> 0b7b03b20acb540d1b06110667359ae61ab17849
xh -> 0b7b03b20acb540d1b06110667359ae61ab17849
zam -> 0b7b03b20acb540d1b06110667359ae61ab17849
zh-CN -> 0b7b03b20acb540d1b06110667359ae61ab17849
zh-TW -> 0b7b03b20acb540d1b06110667359ae61ab17849
…s r=jules,desktop-theme-reviewers" for causing mochitests failures in browser_aboutCertError.js.

This reverts commit 34daa96.
…alize() testing functions, and add a release assert r=spidermonkey-reviewers,iain

Differential Revision: https://phabricator.services.mozilla.com/D281276
…em-reviewers,dshin

This gets all the property metadata from the toml files without
having to invoke mako.

It's not great that I need to move the declaration variant stuff in
there, because it affects the order, but seems fine, and unblocks
the following patch.

Differential Revision: https://phabricator.services.mozilla.com/D281365
…y parsing. r=firefox-style-system-reviewers,dshin

What is going on in this page is:

 * We have two nested references + fallback, both with missing closing
   parens.
 * But the value actually ends with a closing paren, the rgb() function.

So we fail to detect that the closing parens are missing, and we mess up
the indices during substitution because we rely on the fallback end
being the end of the var() reference minus 1.

Properly tests for it by checking the block end against the
outside-of-the-block start. If they're the same there was no closing
paren. We could extend cssparser with this information maybe but for now
this seems ok. UnquotedUrl I think we can leave as-is.

Add two tests, once with a would be successful substitution that we get
wrong right now, but this patch fixes, and the actually crashing test.

I'm a bit surprised that no fuzzer has found this before tbh...

Differential Revision: https://phabricator.services.mozilla.com/D281506
…ild-system-reviewers,taskgraph-reviewers,releng-reviewers,mach-reviewers,ahal,ahochheiden

Differential Revision: https://phabricator.services.mozilla.com/D273841
…h command instead of calling a function to ensure it uses the taskgraph virtual env. r=firefox-build-system-reviewers,taskgraph-reviewers,ahal,ahochheiden

Differential Revision: https://phabricator.services.mozilla.com/D279489
…d RemoveLayer. r=bradwerth

These methods are called by RenderCompositorNative::BeginFrame() if
the pref `gfx.webrender.compositor` is set to false.

Without this fix, setting `gfx.webrender.compositor` to false causes Firefox
windows to be blank.

Differential Revision: https://phabricator.services.mozilla.com/D281511
… efficient r=emilio,dom-storage-reviewers,janv

Current implementation of Maybe type suffers from two performance
issues:

1. it cannot be passed by copy as function argument. Instead, it is
   passed as invisible references, because it has non-trivial move-assign
   and move-copy members.
2. it uses some padding, preventing an internal representation as a flat
   register

It is impossible to solve (1) by defaulting the mentioned members
because we guarantee that the moved object is reset to the empty state.
Fortunately, we can use the [[clang::trivial_abi]] class attribute to
inform the compiler we know what we're doing in that case.

Making the padding explicit does not change the object size but helps
the compiler to generate efficient code.

Differential Revision: https://phabricator.services.mozilla.com/D281077
sstanca-cell and others added 25 commits February 2, 2026 21:26
…bles for bandwidth. r=ip-protection-reviewers,fluent-reviewers,rking,bolsson" for causing mochitets failures in browser_ipprotection_status_card.js.

This reverts commit ef8a6e4.
…top-theme-reviewers,ai-frontend-reviewers,ngrato,sfoster" for causing bc failures @ browser_all_files_referenced.js

This reverts commit ffccb26.
…Tests r=aaronmt

This diff adds structured, timed logging to Android UI test helpers and fixes an issue where tests were waiting on destination pages before navigating. Logs are hierarchical (STEP / CMD / LOC), color-coded, and optimized for human readability and accessibility. Logging lives in helpers (not tests), includes slow warnings and per-test summaries, and integrates with existing factory logging via a bridge. Tests now run ~85% faster and failures are much easier to diagnose locally and in CI.

example log: {F56944852}
For more detailed info, please see Bugzilla ticket: https://bugzilla.mozilla.org/show_bug.cgi?id=2013503

Differential Revision: https://phabricator.services.mozilla.com/D281223
…neDrive personal directory r=cdupuis

After a fresh installation of Windows 10, the registry entry "HKEY_CURRENT_USER\Software\Microsoft\OneDrive\Accounts\Personal\UserFolder" exists even if the user has not signed in to OneDrive.

When the user is signed in, several registry keys are created, including "HKEY_CURRENT_USER\Software\Microsoft\OneDrive\Accounts\Personal\cid", which is the "Customer ID".

This registry key is set when the user is signed in and deleted when the user signs out, so it can be used to determine whether OneDrive is active.

Differential Revision: https://phabricator.services.mozilla.com/D280579
…View and move to the Prompt module r=android-reviewers,android-l10n-reviewers,flod,mavduevskiy

Differential Revision: https://phabricator.services.mozilla.com/D281139
…oken ?bgrins,#ai-models-reviewers,#ai-frontend-reviewers r=ai-models-reviewers,ai-ondevice-reviewers,cdipersio,gregtatum

Differential Revision: https://phabricator.services.mozilla.com/D279938
…Classifier Harmful Add-on feature, r=rpl,data-stewards

Differential Revision: https://phabricator.services.mozilla.com/D280421
…rocess sandbox r=mac-reviewers,bradwerth

Avoid long delays during GPU process startup caused by sandbox
violations on VMs. Add access to additional IO properties and sysctls
and remove a duplicate entry. These changes are similar to the
changes added for bug 1893921 for content process startup delays
on virtual machines.

Differential Revision: https://phabricator.services.mozilla.com/D281138
…fox-style-system-reviewers,dshin

This moves all the css-property-metadata-dependent code generation to
a single file (GenerateCSSProperties.py).

This file knows how to extract all the property metadata and processes
it accordingly.

This unifies:

 * ListCSSProperties.cpp
 * All the consumers of layout/style/ServoCSSPropList.py, which now
   consume the data directly.
 * Various bits of logic to determine e.g. the idl attribute name.
 * etc

And paves the way towards removing mako for code generation, perhaps.

Differential Revision: https://phabricator.services.mozilla.com/D281366
…y-reviewers,mgaudet

The Intl fallback symbol is unique per global, so store it in GlobalIntlData.

Differential Revision: https://phabricator.services.mozilla.com/D279038
… r=spidermonkey-reviewers,mgaudet

Shared support functions for `Intl.DateTimeFormat` and `Intl.NumberFormat` to
support the legacy constructor semantics.

Differential Revision: https://phabricator.services.mozilla.com/D279039
… r=spidermonkey-reviewers,mgaudet

Moving the implementation to C++ also allows to use the C++ type system a bit
better, so this patch is slightly larger compared to the other Intl constructors.

Additionally performed some clean-ups like removing unnecessary `intl::` namespace
prefixes to align the code with the other Intl constructors.

Differential Revision: https://phabricator.services.mozilla.com/D279040
…op-theme-reviewers,akulyk,emilio" for causing mochitests failures in browser_report_preview.js.

This reverts commit 08f82ea.
…th FxA token ?bgrins,#ai-models-reviewers,#ai-frontend-reviewers r=ai-models-reviewers,ai-ondevice-reviewers,cdipersio,gregtatum" for causing bc failures @ browser_ml_openai.js

This reverts commit a8c7903.
…rtManager. r=ip-protection-reviewers,fchasen" for causing bc failures @ browser_ipprotection_alert_manager.js

This reverts commit c74020a.
@pull pull bot locked and limited conversation to collaborators Feb 3, 2026
@pull pull bot added the ⤵️ pull label Feb 3, 2026
@pull pull bot merged commit d8636da into pixeldevel:main Feb 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.