forked from mozilla-firefox/firefox
-
Notifications
You must be signed in to change notification settings - Fork 0
[pull] main from mozilla-firefox:main #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s of clamp(), a=testonly Automatic update from web-platform-tests Add 'none' keyword for upper/lower bounds of clamp() clamp(MIN, VAL, none) is equivalent to max(MIN, VAL) clamp(none, VAL, MAX) is equivalent to min(VAL, MAX) clamp(none, VAL, none) is equivalent to just calc(VAL) Spec: https://drafts.csswg.org/css-values/#funcdef-clamp Fixed: 329302148 Change-Id: I1b0456b289e90bf540fce1e299c52f50891a6823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7516844 Reviewed-by: Daniil Sakhapov <sakhapov@chromium.org> Commit-Queue: Munira Tursunova <moonira@google.com> Cr-Commit-Position: refs/heads/main@{#1575210} -- wpt-commits: 4af83765a2f5708bd7a8534a4db5d659b2cf6619 wpt-pr: 57357
wpt-pr: 57357 wpt-type: metadata
… mutations while the element …, a=testonly Automatic update from web-platform-tests HTML: style load event not fired for DOM mutations while the element is still parsed See whatwg/html#12090 -- wpt-commits: f67ee20aa7eb5a32af7c9fdb7615e0a02f612d62 wpt-pr: 57346
…n CSSNumericValue operations, a=testonly Automatic update from web-platform-tests Throw TypeError for incompatible types in CSSNumericValue operations This patch modifies min(), max(), mul(), and div() to throw a TypeError when types are incompatible. Previously, Chromium returned null in these cases because it used a constructor that did not throw errors. This patch changes the constructors to properly handle these errors, aligning Blink's behavior with the CSS Typed OM specification. [1]: https://drafts.css-houdini.org/css-typed-om-1/#dom-cssnumericvalue-min [2]: https://drafts.css-houdini.org/css-typed-om-1/#dom-cssnumericvalue-max [3]: https://drafts.css-houdini.org/css-typed-om-1/#dom-cssnumericvalue-mul [4]: https://drafts.css-houdini.org/css-typed-om-1/#dom-cssnumericvalue-div Bug: 477036003 Change-Id: I182a7917e30e6361b3d117bad4c99a7622e2252b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7493838 Commit-Queue: Jinho Bang <zino@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Jinho Bang <zino@chromium.org> Cr-Commit-Position: refs/heads/main@{#1575569} -- wpt-commits: 3e32b1b196d97a9ac8f373707a1825f031c156de wpt-pr: 57365
wpt-pr: 57365 wpt-type: metadata
…=testonly Automatic update from web-platform-tests url: more drive letter quirk coverage Firefox 145 fails both. Chromium 143 fails the second. -- wpt-commits: e3c46fdf5587369127de2863a7e38295f4e07f16 wpt-pr: 57356
wpt-pr: 57356 wpt-type: metadata
… for inline style and class attribute changes, a=testonly Automatic update from web-platform-tests [soft navigations] Set up paint tracking for inline style and class attribute changes Changing only an element's inline style or class attribute can cause contenful paints, e.g. toggling display:none (via either method) can display hidden content. This is used on some SPAs, but the corresponding paints are not currently tracked by the soft nav heuristics. This CL sets up paint tracking/attribution for such cases. Notes: - Other attribute changes can cause element re-paints (e.g. changing an ID), but we're starting with style/class to limit the scope of this while covering a large known gap. - This excludes animating the class attribute for SVG, i.e. we're not hooking into ClassAttributeChanged(). This does not seem needed at this point, but can be revisited later if necessary. - This does not handle all style changes, e.g. inserting a new style sheet. We're currently scoping this to inline style changes since we can attribute it at the time of modification. Handling changes to elements known only at style resolution time is currently out of scope. Bug: 40870828 Change-Id: Ie18c5ff26a03c80b14157f6a6051fefcf8c5339e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7512446 Commit-Queue: Scott Haseley <shaseley@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1575581} -- wpt-commits: e3d5424555c03dd46c32f2daa074aefa84c68da7 wpt-pr: 57361
…-start-ignored.html., a=testonly Automatic update from web-platform-tests Add fuzz annotation to WPT fragmented-at-start-ignored.html. (#57369) This test occasionally renders with an imperceptible mismatch (maxDifference of 1) in the blue area at the bottom-left of the test. This patch is just annotating that. -- wpt-commits: f47e795f6c5f833b3318b2ac6e506c566be00996 wpt-pr: 57369
… changes, don't re-fetch, a=testonly Automatic update from web-platform-tests When <link rel=stylesheet> media attribute changes, don't re-fetch This is per-spec, see https://html.spec.whatwg.org/multipage/links.html#link-type-stylesheet Changing the media attribute should affect immediately and not trigger re-processing. Bug: 404755076 Change-Id: I92b5c4e3e6d210988ae685cee55465dd81d617c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7510577 Reviewed-by: Dominic Farolino <dom@chromium.org> Commit-Queue: Noam Rosenthal <nrosenthal@google.com> Cr-Commit-Position: refs/heads/main@{#1575260} -- wpt-commits: 66d5d24159eb3637d00edf8cf3fa2a7b07f5e4a0 wpt-pr: 57358
wpt-pr: 57358 wpt-type: metadata
… shadow host, a=testonly Automatic update from web-platform-tests Fix focus navigation for popover that is shadow host If popover is a shadow host, the focus navigation is scoped to the popover element itself rather than its shadow root. This caused focusable elements inside the shadow DOM to be skipped. This CL adds a check in OwnedByPopoverInvoker() to detect whether the popover is a shadow host, which uses the shadow root as the focus scope. Bug: 402282793 Change-Id: I0bef8f4263dfc9ab83104ebc047769a0cf5c790d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7490209 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Perry <perryuwang@gmail.com> Cr-Commit-Position: refs/heads/main@{#1575635} -- wpt-commits: 2e2e15b1d44551c5798cdd2f26d846f426eb6856 wpt-pr: 57362
…ntRegistry.initialize(), a=testonly Automatic update from web-platform-tests Add missing WPT coverage for CustomElementRegistry.initialize() There are bugs that are not currently caught by the existing WPT tests for initialize(). One example is a bug like [1], which does not occur in Chromium but does occur in WebKit. Since there may be other similar cases, this change adds missing WPT coverage based on [2]. [1] https://bugs.webkit.org/show_bug.cgi?id=299299 [2] https://html.spec.whatwg.org/multipage/custom-elements.html#dom-customelementregistry-initialize Bug: 475579177 Change-Id: Ia503db85844b9a08182275a96fe350b07ef08306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7487391 Reviewed-by: Mason Freed <masonf@chromium.org> Reviewed-by: Jayson Chen <jaysonchen@microsoft.com> Commit-Queue: YeongHan Kim <soosungp33@gmail.com> Cr-Commit-Position: refs/heads/main@{#1575636} -- wpt-commits: 7cc53e677dfae85f4af017ed0d7d59935bdd0947 wpt-pr: 57370
wpt-pr: 57370 wpt-type: metadata
… are defined after initialize(), a=testonly Automatic update from web-platform-tests Fix missing upgrade when custom elements are defined after initialize() According to [1], initialize() should try to upgrade inclusive descendants. The current implementation only upgrades custom elements that are already defined. This can cause upgrades to be skipped when elements are defined after initialize(). So, this patch fixes the bug by also considering not yet defined custom elements. [1] https://html.spec.whatwg.org/#dom-customelementregistry-initialize Bug: 475155079 Change-Id: Idf5ee5baf17d8bfba5f5618d15745b2423844813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7488872 Reviewed-by: Jayson Chen <jaysonchen@microsoft.com> Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: YeongHan Kim <soosungp33@gmail.com> Cr-Commit-Position: refs/heads/main@{#1575645} -- wpt-commits: 9dbd401882f397e1ead33935a827fb606d81e38e wpt-pr: 57363
wpt-pr: 57363 wpt-type: metadata
…ty, a=testonly Automatic update from web-platform-tests Implement the CSS image-animation property Add support for the CSS image-animation property, which controls the animated image playback. The property accepts three values: * normal: Default browser behavior * running: Per-element timeline * paused(tentative): Stop animated image Currently, image animations are managed by ImageAnimationController in the CC layer. The controller manages the animation information, including the next frame index and length, ...etc, via PaintImage's stable_id as a key. The paint image has been created by BitmapImage::Draw and the image shared the resource and paint image across the layout and styles if it has same absolute URL by the WHATWG standard [1]. To pause, we should create new PaintImage with different paint id per each style. Therefore, pass the image animation information to the BitmapImage::Draw() to create different PaintImage by the style. The BitmapImage class now caches multiple PaintImage instances, which are keyed by DOM node ID and the animation state. This enables per-element animation. Another approach is to duplicate the image resource manually. However, this approach introduces another caching complexity on several layers. Therefore, we will not pursue this approach. Removing "reftest-wait" does not capture the pixels at the exact time on the Mac and it will cause flakiness. Therefore, the exception of -running test suites on Mac has been added to TestExpectations. [1] https://html.spec.whatwg.org/multipage/rendering.html#images-3 Explainer: https://github.com/webplatformco/project-image-animation/tree/main/image-animation-property Unofficial Draft: https://webplatform.design/projects/image-animation/image-animation-property/spec/overview Intent to prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/0kUk5-6TAfM/m/7YVGLKzEBwAJ Chromestatus Entry: https://chromestatus.com/feature/5078177326170112 Bug: 429459566 Change-Id: I6e5b6d6cccf6419c7c7c817a7082409e69a9c406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7458159 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Seokho Song <seokho@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/main@{#1575651} -- wpt-commits: 784717ed4f28e7aca937a92c421789228f05e3c9 wpt-pr: 57371
wpt-pr: 57371 wpt-type: metadata
…ce.https.html, a=testonly Automatic update from web-platform-tests Use t.step_timeout in fetch-frame-resource.https.html Replace setTimeout with t.step_timeout in fetch-frame-resource.https.html to follow WPT best practices for timer-based tests. This ensures better integration with the test harness and proper timeout handling. Bug: w3c/ServiceWorker#1194 Change-Id: I02c796593546fc39f1e44b6c4ac72ee7b2f752e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7509313 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/main@{#1575654} -- wpt-commits: 5b572b42716bb759500521d6a6b47318cf07d4cc wpt-pr: 57372
…in`, & `overflow-wrap`, a=testonly Automatic update from web-platform-tests Map `overflow-clip`, `overflow-clip-margin`, `overflow-wrap` (#56778) Feature: `overflow-clip` Reference: https://github.com/web-platform-dx/web-features/blob/main/features/overflow-clip.yml Notable exclusions 1. `css/css-overflow/overflow-clip-margin-*` - Mapped to `overflow-clip-margin`. 2. `css/css-view-transitions/*` - Primary focus is View Transitions. 3. `css/css-position/sticky/*` - Primary focus is sticky positioning behavior. 4. `css/css-flexbox/*` and `css/css-grid/*` - Layout tests where overflow-clip is secondary context. 5. `css/CSS2/positioning/*` - Legacy tests for overflow clipping in CSS2.1 context. Feature: `overflow-clip-margin` Reference: https://github.com/web-platform-dx/web-features/blob/main/features/overflow-clip-margin.yml Feature: `overflow-wrap` Reference: https://github.com/web-platform-dx/web-features/blob/main/features/overflow-wrap.yml Notable exclusions 1. `css/css-text/white-space/*` - Primary focus is `white-space` property or `break-spaces` value interaction. 2. `css/css-text/word-break/*` - Primary focus is `word-break` property. 3. `css/css-overflow/line-clamp/*` - Primary focus is `line-clamp` / `block-ellipsis`. 4. `css/css-pseudo/marker-overflow-wrap.html` - Excluded as it overlaps strongly with `::marker` Co-authored-by: Philip Jägenstedt <philip@foolip.org> -- wpt-commits: 6dac99edd4d9d0746e713b2bb31e183beadbad2b wpt-pr: 56778
…n property", a=testonly Automatic update from web-platform-tests Revert "Implement the CSS image-animation property" This reverts commit 0383d249f4843bcc19dbb6d201cc76d169c60cd7. Reason for revert: suspect causing blink_unittests failure on Linux UBSan Test. blink_unittests failed because of: - LayoutSelectionTest.TraverseLayoutObjectListStyleImage - LayoutTextCombineTest.ListItemStyleToImage - StyleResolverTest.CSSMarkerPseudoElement - UseCounterImplTest.CSSMarkerPseudoElementUA First build failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20UBSan%20Tests/13361/ Original change's description: > Implement the CSS image-animation property > > Add support for the CSS image-animation property, which controls the > animated image playback. The property accepts three values: > > * normal: Default browser behavior > * running: Per-element timeline > * paused(tentative): Stop animated image > > Currently, image animations are managed by ImageAnimationController in > the CC layer. The controller manages the animation information, > including the next frame index and length, ...etc, via PaintImage's > stable_id as a key. > > The paint image has been created by BitmapImage::Draw and the image > shared the resource and paint image across the layout and styles if it > has same absolute URL by the WHATWG standard [1]. > > To pause, we should create new PaintImage with different paint id per > each style. > > Therefore, pass the image animation information to the > BitmapImage::Draw() to create different PaintImage by the style. The > BitmapImage class now caches multiple PaintImage instances, which are > keyed by DOM node ID and the animation state. This enables per-element > animation. > > Another approach is to duplicate the image resource manually. However, > this approach introduces another caching complexity on several layers. > Therefore, we will not pursue this approach. > > Removing "reftest-wait" does not capture the pixels at the exact time on the Mac and it will cause flakiness. Therefore, the exception of -running test suites on Mac has been added to TestExpectations. > > [1] https://html.spec.whatwg.org/multipage/rendering.html#images-3 > > Explainer: https://github.com/webplatformco/project-image-animation/tree/main/image-animation-property > Unofficial Draft: https://webplatform.design/projects/image-animation/image-animation-property/spec/overview > Intent to prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/0kUk5-6TAfM/m/7YVGLKzEBwAJ > Chromestatus Entry: https://chromestatus.com/feature/5078177326170112 > > > Bug: 429459566 > Change-Id: I6e5b6d6cccf6419c7c7c817a7082409e69a9c406 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7458159 > Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> > Commit-Queue: Seokho Song <seokho@chromium.org> > Reviewed-by: Florin Malita <fmalita@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1575651} Bug: 429459566 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ia26f9cef7a639659c289c50fae761fc412839e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7526465 Owners-Override: Takashi Sakamoto <tasak@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Takashi Sakamoto <tasak@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1575715} -- wpt-commits: c429533bc423f92d4605fd7c9106d4a347faf00d wpt-pr: 57373
…pace shortage., a=testonly Automatic update from web-platform-tests Column balancing: Include ruby text in space shortage. When measuring the fragment block-size when determining whether it fits in the current column or not, we use BlockSizeForFragmentation(), which includes space taken up by ruby text (which isn't part of the "raw" block-size of the fragment). If a fragment is found not to fit, we calculate space shortage (to stretch the columns and try again). We need to do the same here, i.e. use BlockSizeForFragmentation() rather than the "raw" fragment size. Otherwise no shortage will be detected. One existing test now ends up with a more ideal column height than before, and has therefore been rebaselined. Bug: 391504025 Change-Id: Ib8cb5acb2eacec8cd8af8b728d73f85550a0e961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7510938 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1575732} -- wpt-commits: f90007795de2d5f20c23a68109358e0d7ca6e3e1 wpt-pr: 57368
wpt-pr: 57368 wpt-type: metadata
…n default, a=testonly Automatic update from web-platform-tests Drop 'portrait' from size descriptor when default All the named sizes have a size which is portrait by default. Serialization will be more minimal, and wpt test starts passing. Bug: 356917017 Change-Id: I2188597890993be0bca1be229f0a3194bd36e5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7524025 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1575737} -- wpt-commits: 9c9679edcd05f5e75c5b93c0ad8d90f8359bb98b wpt-pr: 57374
wpt-pr: 57374 wpt-type: metadata
…content from floats., a=testonly Automatic update from web-platform-tests Column balancing: Propagate unbreakable content from floats. Since we don't have access to the fragment builder during float layout (because of how inline layout works), extra efforts are required to propagate the tallest piece of unbreakable content in floats. Refactor the code a little, so that this can easily be calculated and propagated on the outside of MovePastBreakpoint(). The new test multicol-fill-balance-032.html turned out to be pretty similar to the legacy test fast/multicol/balance-float-in-inline.html (which now would pass), so just remove that one. Bug: 394900337 Change-Id: I7c9852ca8aacc7edcdbb474973074eb0dd4dba89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7520768 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1575785} -- wpt-commits: 4dba16409cc0b1cde414b7f79d745798afbbe2c0 wpt-pr: 57367
… between NU/AL/AI/ID characters to respect `word-break: keep-all`, a=testonly Automatic update from web-platform-tests layout: Fixed linebreaking logic when . A better solution would be to use , however doesn't accept any arguments with version yet. TODO: fix the logic once can be upgraded to Signed-off-by: Richard Tjokroutomo <richard.tjokro2@gmail.com> -- wpt-commits: e62782e71275056758e05e56d1d58968a5106c4e wpt-pr: 57375
…ests, a=testonly Automatic update from web-platform-tests [WPT] Fix connect-src-webtransport CSP tests I believe the third test in connect-src-webtransport-allowed.sub.https.html is supposed to check that even if a WebTransport connection is initiated specifying some serverCertificateHashes, the connection is not allowed by CSP unless CSP contains the new keyword 'unsafe-webtransport-hashes'. This CL also fixes a minor issue with WPT templating in the tests. Bug: 477304103 Change-Id: Ifa251a3a314e4cc6eb802f24b92445c847d74049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7502859 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/main@{#1575792} -- wpt-commits: 332c31a916993d86f9bca30d0a4aa0f65310eceb wpt-pr: 57376
wpt-pr: 57376 wpt-type: metadata
…ins., a=testonly Automatic update from web-platform-tests Column balancing: Account for float margins. Margins on floats are special, since they cannot collapse with anything, not even fragmentainer boundaries. Bug: 41481415 Change-Id: I1749604ed4189b4b38e8abc3c64aba3e4e327142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7521364 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1575794} -- wpt-commits: 4e13d7494b60530e0708c96897aa004a7cc59354 wpt-pr: 57366
…er thread. r=gfx-reviewers,sotaro Creating the new Renderer when creating a WebRenderAPI must occur on the Renderer thread. Previously WebRenderAPI::Create() dispatched a synchronous task to the Renderer thread to achieve this. This patch instead dispatches asynchronously and WebRenderAPI::Create() now returns a promise. When that promise resolves, CompositorBridgeParent will complete its initialisation of the WebRenderBridgeParent. For now, WebRenderBridgeChild::SendEnsureConnected() must still be called prior to using the WebRenderBridge. WebRenderBridgeParent::RecvEnsureConnected() ensures that its initialization has completed before returning. Note that in practice this means we still end up blocking synchronously for the Renderer to be created on the Renderer thread. Making WebRenderLayerManager initialize asynchronously will follow in later patches. Differential Revision: https://phabricator.services.mozilla.com/D276873
…ld. r=gfx-reviewers,sotaro We were using mProcessToken as a proxy for whether the UiCompositorControllerParent lived in the GPU process or the parent process. However, prior to SetCompositorSurfaceManager being called the actor may have been destroyed and the value set to zero, incorrectly triggering the assertion. Note this issue is not directly caused by the other patches in this series, but it was discovered whilst working on them, and perhaps made more likely to occur by the timing changes they introduced. Differential Revision: https://phabricator.services.mozilla.com/D276874
…r=layout-reviewers,jwatt,dom-core,mccr8 If during shutdown the widget's WebRenderLayerManager creation fails, then a subsequent RemoteLayerTreeOwner::EnsureLayersConnected() call will be unable to create a new layer manager from which to access the CompositorBridgeChild and call SendNotifyChildRecreated(). When the puppet widget then attempts to create its layer manager, this will result in a GPU process assertion due to the layers ID not being mapped in ContentCompositorBridgeParent::AllocPWebRenderBridgeParent. To avoid this, we make SendEnsureLayersConnected() fallible. If it is unable to connect layers, then BrowserChild retains the stale layer manager briefly until it is subsequently shut down. Note this issue is not directly caused by the other patches in this series, but it was discovered whilst working on them, and perhaps made more likely to occur by the timing changes they introduced. Differential Revision: https://phabricator.services.mozilla.com/D276875
…nspaille This type was implemented in bug 1975188. The implementation declared the out-of-line `CrashFmtImpl` method as a template method, and only put the implementation in the .cpp file, so an implementation will never be found by the linker, and it cannot be used. The approach of removing the macro was preferred over fixing it, as it has no users, and fixing it would have required "fmt/base.h" to be included in every TU which includes Assertions.h If we ever intend to add something like this in the future, it should be added to a different header file. Differential Revision: https://phabricator.services.mozilla.com/D281560
…of a multiselection r=tabbrowser-reviewers,desktop-theme-reviewers,sclements Differential Revision: https://phabricator.services.mozilla.com/D280051
…ions consistent with other suggestions. r=daisuke This essentially reverts bug 1836582. Differential Revision: https://phabricator.services.mozilla.com/D281551
…wers,fluent-reviewers,flod,mimi See [[ https://www.figma.com/design/5KuePTGmOEUFyCHBHCsGim/AI-Mode-%E2%80%94%C2%A0MVP-Scope-Design?node-id=15716-32755&t=KcZgdc8gJ2GXXnRb-0 | figma ]] for the existing users Smart Window Firefox ToU modal. Differential Revision: https://phabricator.services.mozilla.com/D280755
…he window states, size and position. r=Sasha Differential Revision: https://phabricator.services.mozilla.com/D279764
…sed projects, r=taskgraph-reviewers,jcristau Differential Revision: https://phabricator.services.mozilla.com/D281461
…fig r=android-reviewers,petru Differential Revision: https://phabricator.services.mozilla.com/D281146
…age info). r=smaug Differential Revision: https://phabricator.services.mozilla.com/D281590
…nt. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D281596
…reviewers Differential Revision: https://phabricator.services.mozilla.com/D280782
…-reviewers,nbarrett Differential Revision: https://phabricator.services.mozilla.com/D281272
…Frame::AppendFrames(). r=layout-reviewers,emilio We can correctly append elements into a multicol container even when they have column-span descendants, so remove the assertion to allow this operation. The WPT added in this patch triggers the assertion in the old code. Differential Revision: https://phabricator.services.mozilla.com/D281580
…mozilla` r=RyanVM" on devs request. This reverts commit fe023f4.
…al` for Linux builds r=RyanVM" on devs request. This reverts commit 40350e0.
…fallback r=glandium,omc-reviewers,toolkit-telemetry-reviewers,emcminn" on devs request. This reverts commit 7f7e182.
…lating the window states, size and position. r=Sasha" for causing remote failures @ browser_WindowManager.js This reverts commit cffcc7b.
…r=bwc" for causing build bustages This reverts commit 169b182. Revert "Bug 2013368 - don't use 'class' for variable name. r=dbaker" This reverts commit 7b8c4e1. Revert "Bug 2013368 - make sure all vars are initialized before potential ABORT macro usage. r=bwc" This reverts commit 7606f45. Revert "Bug 2013368 - add fallthrough annotations to nICEr. r=dbaker" This reverts commit 5d5c4b6.
…ng where possible. r=bwc" This reverts commit a545bd5.
…for causing build bustages This reverts commit b1c50f2. Revert "Bug 2012866 - const char* fixes in nICEr. r=dbaker" This reverts commit a044ecd. Revert "Bug 2012866 - make passing NR_registry pointers const char* r=bwc" This reverts commit 7ef2996. Revert "Bug 2012866 - const char* fixes in nrappkit's log and registry directories r=dbaker" This reverts commit 1679ba0. Revert "Bug 2012866 - const char* fixes in nrappkit's util directory. r=dbaker" This reverts commit 002f945. Revert "Bug 2012866 - const char* fixes for nrappkit's r_errors.* r=bwc" This reverts commit fb00f85. Revert "Bug 2012866 - const char* fixes for nr_reg_type_name and nr_reg_action_name. r=dbaker" This reverts commit a60d980. Revert "Bug 2012866 - cast all the void* cb_arg assignments. r=dbaker" This reverts commit e789a3a. Revert "Bug 2012866 - remove unused functions nr_reg_compute_type and nr_strerror_r. r=bwc" This reverts commit 2c5b07f.
…ILD CLOSED TREE ach -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 af -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 an -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ar -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ast -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 az -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 be -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 bg -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 bn -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 bo -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 br -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 brx -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 bs -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ca -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ca-valencia -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 cak -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ckb -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 cs -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 cy -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 da -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 de -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 dsb -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 el -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 en-CA -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 en-GB -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 eo -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 es-AR -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 es-CL -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 es-ES -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 es-MX -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 et -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 eu -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 fa -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ff -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 fi -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 fr -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 fur -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 fy-NL -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ga-IE -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 gd -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 gl -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 gn -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 gu-IN -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 he -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 hi-IN -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 hr -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 hsb -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 hu -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 hy-AM -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 hye -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ia -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 id -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 is -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 it -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ja -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ja-JP-mac -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ka -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 kab -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 kk -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 km -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 kn -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ko -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 lij -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 lo -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 lt -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ltg -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 lv -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 meh -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 mk -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ml -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 mr -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ms -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 my -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 nb-NO -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ne-NP -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 nl -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 nn-NO -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 oc -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 pa-IN -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 pl -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 pt-BR -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 pt-PT -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 rm -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ro -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ru -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 sat -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 sc -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 scn -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 sco -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 si -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 sk -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 skr -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 sl -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 son -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 sq -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 sr -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 sv-SE -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 szl -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ta -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 te -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 tg -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 th -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 tl -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 tr -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 trs -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 uk -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ur -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 uz -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 vi -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 wo -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 xh -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 zh-CN -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 zh-TW -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8
…LD CLOSED TREE ach -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 an -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ar -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ast -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 az -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 be -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 bg -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 bn -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 br -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 bs -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ca -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 cak -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 cs -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 cy -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 da -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 de -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 dsb -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 el -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 en-CA -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 en-GB -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 eo -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 es-AR -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 es-CL -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 es-ES -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 es-MX -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 et -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 eu -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 fa -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ff -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 fi -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 fr -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 fy-NL -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ga-IE -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 gd -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 gl -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 gn -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 gu-IN -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 he -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 hi-IN -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 hr -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 hsb -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 hu -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 hy-AM -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ia -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 id -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 is -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 it -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ja -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ka -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 kab -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 kk -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 km -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 kn -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ko -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 lij -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 lo -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 lt -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ltg -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 lv -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 meh -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 mix -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ml -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 mr -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ms -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 my -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 nb-NO -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ne-NP -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 nl -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 nn-NO -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 oc -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 pa-IN -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 pl -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 pt-BR -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 pt-PT -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 rm -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ro -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ru -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 sk -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 sl -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 son -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 sq -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 sr -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 sv-SE -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ta -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 te -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 th -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 tl -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 tr -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 trs -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 uk -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 ur -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 uz -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 vi -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 wo -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 xh -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 zam -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 zh-CN -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8 zh-TW -> ecdfdca74a53222f4937e831829de0ab6e1ee5f8
…BuildConfig r=android-reviewers,petru" for causing fenix debug failures This reverts commit cd6583e.
… StorageIPC. r=dom-storage-reviewers,asuth Differential Revision: https://phabricator.services.mozilla.com/D281460
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )