[pull] main from mozilla-firefox:main #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kit-telemetry-reviewers,bolsson,chutten Differential Revision: https://phabricator.services.mozilla.com/D277825
We had a spurious assert that was occasionally firing when doing a useless array.copy (same base pointer for src and dst, same number of elements obviously). In theory this assert maybe implies that this should be handled upstream (and for baseline, it is handled), but in my opinion it is fine for the early-out to happen in the move method itself rather than being an invariant enforced by the caller. Note that because this was a normal assert, not a release assert, this hasn't been happening in releases anyway. And this is fine, because falling through to either a gc::BarrieredMoveRangeImpl or a memmove will not cause problems, as both functions handle an equal src/dst just fine. It is incredible, frankly, that neither the spec tests nor our own array tests caught this. Differential Revision: https://phabricator.services.mozilla.com/D281513
…ontend-reviewers,ai-models-reviewers,bjohns,omarg Add run_search tool that navigates the main tab to a SERP, extracts page content, and returns it to the LLM to continue the conversation in the sidebar. Fix phantom copy/regenerate buttons after search handoff by filtering empty and function-type assistant messages from renderState(). Differential Revision: https://phabricator.services.mozilla.com/D281072
…menu. r=ip-protection-reviewers,desktop-theme-reviewers,tgiles,rking Differential Revision: https://phabricator.services.mozilla.com/D281233
…fault r=android-reviewers,petru Differential Revision: https://phabricator.services.mozilla.com/D281541
While it's frustrating and kind of annoying to rename metrics, development showed that it was overly confusing and messy having multiple naming methods - sometimes things were snake, sometimes Camel sometimes lowercase. This normalizes them. Since we're doing a whole new round of data collection it won't impede things too much. Differential Revision: https://phabricator.services.mozilla.com/D280495
…ow) r=timhuang Differential Revision: https://phabricator.services.mozilla.com/D277459
…huster Differential Revision: https://phabricator.services.mozilla.com/D279922
While we collect some of these using C++, this will more accurately record what fingerprinters see. Differential Revision: https://phabricator.services.mozilla.com/D279923
… startup analysis. r=perftest-reviewers,kshampur Differential Revision: https://phabricator.services.mozilla.com/D281273
…ers,toolkit-telemetry-reviewers,bolsson,chutten" for causing xpc failures @ test_TelemetrySession.js This reverts commit f093388.
… r=ai-frontend-reviewers,ai-models-reviewers,bjohns,omarg" for causing bc failures on browser_conversation_stream.js. This reverts commit 71e4ebe.
…ak,places-reviewers Differential Revision: https://phabricator.services.mozilla.com/D281229
…kpour,android-reviewers We have an example of a Login created in the `PasswordGeneratorDialogFragment` that is passed back to callback, however we work around the hint provided from Gecko, but trying to modify the Login on confirmation. What this turns into is re-implemented logic in GeckoPromptDelegate with checks that we wouldn't need if we simply forwarded the hint onward. The `Login.guid` API is also a lie that we require it to exist. This seems to be because it was an API for _retrieving_ a Login from the storage layer which is now used for storing it. Differential Revision: https://phabricator.services.mozilla.com/D281382
…droid-reviewers Differential Revision: https://phabricator.services.mozilla.com/D281383
…=ai-ondevice-reviewers Differential Revision: https://phabricator.services.mozilla.com/D277622
… bandwidth. r=ip-protection-reviewers,fluent-reviewers,rking,bolsson Differential Revision: https://phabricator.services.mozilla.com/D280438
…e-reviewers,ai-frontend-reviewers,ngrato,sfoster Differential Revision: https://phabricator.services.mozilla.com/D280655
…r=handyman But NetworkGeolocationProvider can't be removed as it's still needed to be served as a mock provider for WPT. We can try replacing it with a simpler one if we ever decide to fully remove NetworkGeolocationProvider, but doing so doesn't sound particularly useful not right now. Differential Revision: https://phabricator.services.mozilla.com/D281075
…ndroid builds r=firefox-build-system-reviewers,geckoview-reviewers,jcristau,sergesanspaille,tcampbell Differential Revision: https://phabricator.services.mozilla.com/D281153
# ignore-this-changeset
…bles for bandwidth. r=ip-protection-reviewers,fluent-reviewers,rking,bolsson" for causing bc failures @ browser_ipprotection_status_card.js This reverts commit 688ee55.
…a selected split view r=desktop-theme-reviewers,tabbrowser-reviewers,jsudiaman,emilio Differential Revision: https://phabricator.services.mozilla.com/D280990
…allSeek logs. r=media-playback-reviewers,padenot Differential Revision: https://phabricator.services.mozilla.com/D281623
…ng the mouse into and out of an iframe; r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D280338
…s to iframe that lives in different process; r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D280339
… possible. r=bwc Differential Revision: https://phabricator.services.mozilla.com/D280995
…RT macro usage. r=bwc Differential Revision: https://phabricator.services.mozilla.com/D281088
This ensures history has been updated before moving on. It also adds some improved pop-up waiting, even though they don't fully fix the intermittent, hence we disable the test on the affected platforms. Differential Revision: https://phabricator.services.mozilla.com/D281417
…s r=firefox-build-system-reviewers,glandium Differential Revision: https://phabricator.services.mozilla.com/D281651
…oders. r=media-playback-reviewers,jolin This patch ensure that we do not create hardware backed video decoders when the pref is set to false, including H264/HEVC decoders. This allows various canvas related mochitests to now pass which currently disable all Android MediaCodec decoders. It also adds a new pref, just for Android, media.ffvpx-hw.minimal, which allows for H264/HEVC decoding/encoding, but nothing else. Differential Revision: https://phabricator.services.mozilla.com/D277814
… functionality r=desktop-theme-reviewers,akulyk,tgiles" for causing bc failures @ browser_backup_visibility This reverts commit d3b65ef. Revert "Bug 1995062 - Part 3: fix backup-settings tests r=cdupuis,akulyk" This reverts commit 93c2ac4. Revert "Bug 1995062 - Part 2: convert backup-settings to match new settings UI r=fluent-reviewers,desktop-theme-reviewers,cdupuis,bolsson,akulyk,tgiles" This reverts commit 9f688bc. Revert "Bug 1995062 - Part 1: render backup-settings via config r=fluent-reviewers,desktop-theme-reviewers,cdupuis,bolsson,akulyk,tgiles" This reverts commit 9a0cd66.
…fox-build-system-reviewers,glandium Differential Revision: https://phabricator.services.mozilla.com/D280450
…top-theme-reviewers,ai-frontend-reviewers,ngrato,sfoster" for causing process crashes @ browser_aiwindow_new_chat_button.js This reverts commit b42402e.
…ux builds r=firefox-build-system-reviewers,glandium" for causing build bustages This reverts commit 5c21743.
…cuts row. r=home-newtab-reviewers,reemhamz Differential Revision: https://phabricator.services.mozilla.com/D281540
This makes a few small fixes and cleanup for Suggest row UI standardization: Set the `type` attribute on Nova rows like it's set on other rows so that we can apply styling to them depending on result type. This revision doesn't add any new rules that use `type`, but there are some existing rules that were no longer being applied after we added Nova rows in D279106. Setting `type` on Nova rows restores those rules. Remove the 38px icon size from the CSS since it's not used. Remove the "Keep the status quo" styling for sponsored (AMP) suggestions that made them the same height as typical rows. With this change, they're now their natural height rather than having no padding. I checked with Nive and Paul about that. Differential Revision: https://phabricator.services.mozilla.com/D281252
This commit fixes the single location where didDestroy is not correctly being checked in GenAIChild.sys.mjs, which is affecting the AI controls in about:settings. This commit makes only a minimal change, since it will need to be uplifted into late beta. The GenAI parent and child actors still need a full treatment of didDestroy checks in their async calls. Differential Revision: https://phabricator.services.mozilla.com/D281537
…pdfjs` on Release Android r=firefox-build-system-reviewers,glandium Differential Revision: https://phabricator.services.mozilla.com/D281676
…e-reviewers,ai-frontend-reviewers,ngrato,sfoster Differential Revision: https://phabricator.services.mozilla.com/D280655
…r=ai-models-reviewers,Mardak Differential Revision: https://phabricator.services.mozilla.com/D280875
…keyboard resizing of split views. r=emilio,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,layout-reviewers,bolsson,nsharpley,@tabbrowser-reviewers,ayeddi * xul:splitter remains non-focusable by default to avoid blowing up the scope of this patch * opt-in the splitview splitter to be focusable * Wire up aria attributes on splitview splitter to cue AT on the resizing behavior * New string for the aria-label on the splitview splitter * Make the isSplitViewActive setter a setSplitViewActive method as there's no getter * Add test coverage for the keyboard events on the splitter widget, and the splitview splitter Differential Revision: https://phabricator.services.mozilla.com/D281109
…provided a SurfaceTextureHost. r=gfx-reviewers,lsalzman One can supply SurfaceDescriptorGPUVideo to WebGL for drawing which is backed by a SurfaceTextureHost. It cannot get a surface for drawing into a GL context from a SurfaceTextureHost so we crash because it was previously only used for ShmemTextureHost/BufferTextureHost. This patch relaxes the condition and just notes in the gfx log that we failed to get a surface. Differential Revision: https://phabricator.services.mozilla.com/D281689
…eviewers,necko-reviewers,valentin,ErichDonGubler,firefox-build-system-reviewers,ahochheiden The windows-link crate is similar to the windows-targets crate, but it relies on raw-dylibs, which don't work properly on i686-pc-windows-gnu. We reuse our windows-targets code to replace windows-link, and reexport the contents of windows-link in windows-targets. Consequently, we need to manually indicate to the linker we need some extra libraries because we don't use raw-dylibs anymore. Differential Revision: https://phabricator.services.mozilla.com/D275134
…top-theme-reviewers,ai-frontend-reviewers,ngrato,sfoster" for causing process crashes @ browser_aiwindow_new_chat_button.js This reverts commit 53da5c9.
… functionality (inProgress: true). r=Standard8,fluent-reviewers,akulyk,bolsson" for causing bc failures on browser_search_userEngineDialog.js. This reverts commit 8504125.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )