[pull] main from mozilla-firefox:main#365
Merged
pull[bot] merged 17 commits intopixeldevel:mainfrom Feb 5, 2026
Merged
Conversation
…ed,nrishel,shtrom Differential Revision: https://phabricator.services.mozilla.com/D281873
…droid-reviewers,devota Remove legacy Pocket sponsored stories (spocs) integration from Fenix UI and state management. This code has been superseded by the MARS (Mozilla Ad Routing Service) sponsored content. Changes: - Removed pocketSponsoredStories field from ContentRecommendationsState - Removed PocketSponsoredStoriesChange action from AppAction - Updated ContentRecommendationsReducer to remove spocs handling - Removed useSponsoredStoriesState parameter and getFilteredSponsoredStories() from AppState.kt - Updated PocketMiddleware to remove spocs impression recording - Removed PocketSponsoredStory handling from PocketStoriesController - Removed legacy spocs settings: pocketSponsoredStoriesProfileId, pocketSponsoredStoriesSiteId, pocketSponsoredStoriesCountry, pocketSponsoredStoriesCity - Removed Profile and sponsoredStoriesParams from Core.kt PocketStoriesConfig - Deleted SponsoredStoriesSettingsFragment and related navigation - Updated tests to remove spocs-related test cases Differential Revision: https://phabricator.services.mozilla.com/D281137
…components r=android-reviewers,devota Remove the Pocket Spocs orchestration for legacy sponsored stories, including use cases, repository, API layer, and data types. Changes: - Removed spocsUseCases property from PocketStoriesService - Removed methods: refreshSponsoredStories(), getSponsoredStories(), recordStoriesImpressions(), deleteProfile() - Removed SponsoredStories object from GlobalDependencyProvider - Deleted entire spocs/ directory containing: - SpocsUseCases.kt with use cases for getting and refreshing spocs - SpocsRepository.kt for data access - API layer: SpocsEndpoint.kt, SpocsEndpointRaw.kt, SpocsProvider.kt, SpocsJSONParser.kt, ApiSpoc.kt - Database layer: SpocsDao.kt - Updated tests to remove spocs-related test cases Differential Revision: https://phabricator.services.mozilla.com/D281142
…fig r=android-reviewers,petru Differential Revision: https://phabricator.services.mozilla.com/D281146
…ur,android-reviewers Differential Revision: https://phabricator.services.mozilla.com/D281770
…malekpour,android-reviewers Differential Revision: https://phabricator.services.mozilla.com/D281787
…rai,smaug Differential Revision: https://phabricator.services.mozilla.com/D281802
… r=arai Differential Revision: https://phabricator.services.mozilla.com/D281804
…ewers,data-stewards,emcminn,frontend-codestyle-reviewers This adds a new tile type that renders a textarea for free responses. It can be assigned a configurable character limit, which will render a character counter in the UI. In theory, special message actions can be executed with the text input by the user, but this is not necessary for upcoming messages so has not been implemented. Instead, the input text is recorded as `TEXT_INPUT` telemetry on the `microsurvey` ping. Separate from the configured character limit, there is a data size limit of 8KB. Users will not encounter it in practice because the character limit will prevent the submit button from working. But a message could mistakenly be configured without a character limit, in which case the data limit would kick in and truncate the value in telemetry. Because of privacy and security concerns identified in sensitive data collection review, I have also added a new message property `write_in_microsurvey`, which prevents `client_id` from being collected. Instead, `impression_id` will be collected, which allows joining events from the same message but disallows joining with other datasets. This makes the write-in response more anonymous. It also causes the events to be sent on a different ping, `microsurvey`, rather than the existing, unrestricted `messaging-system` ping. The new `microsurvey` ping will have strict access control, OHTTP, and a shorter retention period. The write-in response value is encoded in a new telemetry metric called `event_input_value`. It is internally carried on the `event_context` metric, but it is deleted from this metric before collection, since the `event_context` would otherwise be Category 2, but including `event_input_value` ratchets it up to 3 or even 4. This way the sensitive stuff is contained within one new metric and can be tracked with it. We will create an unrestricted derivative dataset from the new `microsurvey` ping that includes just the non-sensitive data, so it can be visualized on a Looker dashboard. This leaves the original dataset, including the `event_input_value` write-in response, as data that can only be queried by members of a microsurvey Data Access Workgroup that we're creating. I have provided a temporary test message for review. You can just open a new tab and close it to trigger the test message. To see the telemetry, interact with the test message and then visit about:glean. There, click the Manual Testing tab, and select `microsurvey` from the menulist dropdown in step 2. Click the Apply settings and submit ping button in step 4. Visit the ping viewer in step 5, log into your LDAP account, and look for `microsurvey` pings. These pings should omit `client_id` but include `impression_id`. You should not see `messaging-system` pings for any of the impression or interaction events. The new component and related properties are tested in unit tests. The new `write_in_microsurvey` data collection policy is tested in xpcshell tests. Differential Revision: https://phabricator.services.mozilla.com/D279448
…l picker placeholder icons r=pdahiya,ai-frontend-reviewers [[ https://www.figma.com/design/5KuePTGmOEUFyCHBHCsGim/AI-Mode-%E2%80%94%C2%A0MVP-Scope-Design?node-id=17060-105803&t=2G1Q6YnqeT2WkuDs-0 | Figma link ]] Differential Revision: https://phabricator.services.mozilla.com/D280705
…reviewers,ahal Differential Revision: https://phabricator.services.mozilla.com/D281788
…huster Differential Revision: https://phabricator.services.mozilla.com/D279922
While we collect some of these using C++, this will more accurately record what fingerprinters see. Differential Revision: https://phabricator.services.mozilla.com/D279923
…al races. r=rhunt. js/src/jit-test/tests/wasm/excessive-inlining.js is poorly designed, being timing-dependent and hence failing intermittently, especially on slow machines. It is nevertheless important in that it checks that Ion's wasm-inlining-budget machinery works. This patch reimplements it to be race-free. Code::metadataAnalysis() can now return to JS, the sizes of the Tier-1 and -2 code, and these can be used as the basis for checking that inlining budgets work. There are also a number of reference sizes documented as an aid to future development/changes here. Differential Revision: https://phabricator.services.mozilla.com/D280734
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )