[pull] main from mozilla-firefox:main #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dy to run free" to the existing "Welcome to Firefox" string. r=android-reviewers,android-l10n-reviewers,flod,marcin Differential Revision: https://phabricator.services.mozilla.com/D281751
…UI test r=aaronmt The UI test was disabled when the TranslationOptionsDialog has been updated to use the M3 switch component SwitchListItem in [[ https://phabricator.services.mozilla.com/D278981 | D278981 ]] Removed the assertions that checked that the options are enabled (after the change, their state is always enabled), and only left the assertions in which we check if the options are checked. The UI test successfully passed 50x on Firebase ✅ Differential Revision: https://phabricator.services.mozilla.com/D281953
…ler-reviewers,dcarver Differential Revision: https://phabricator.services.mozilla.com/D281893
…nsole.timeStamp r=dcarver Before we switched to the Firefox Profiler in the DevTools, we had timeline markers for these console methods. But apparently, since we did the switch, we never added markers for them. From our conversations with Chrome folks, they mentioned that some JS frameworks started using these instead of performance.mark/measure combinations especially the console.timeStamp one since it's just an instant marker, stating that they are higher overhead. Even though I don't completely understand their rationale, I think it makes sense to add markers for these methods. It essentially adds 2 different subtypes that uses the same ConsoleTimingMarker. 1. console.time and console.timeEnd when combined create a duration marker with a label, similar to performance.mark and measure. 2. console.timeStamp creates an instant marker with a label. One edge case is that, console.timeEnd doesn't create any markers when it doesn't have a console.time with the same title, and vice versa. Differential Revision: https://phabricator.services.mozilla.com/D281521
…meStamp methods r=dcarver,profiler-reviewers Differential Revision: https://phabricator.services.mozilla.com/D281522
…d-reviewers,tcampbell Differential Revision: https://phabricator.services.mozilla.com/D281898
…-reviewers,kcochrane Differential Revision: https://phabricator.services.mozilla.com/D281263
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )