[pull] main from mozilla-firefox:main#368
Merged
pull[bot] merged 248 commits intopixeldevel:mainfrom Feb 6, 2026
Merged
Conversation
…ewers,desktop-theme-reviewers,cdupuis,bolsson,akulyk,tgiles Differential Revision: https://phabricator.services.mozilla.com/D279015
…I r=fluent-reviewers,desktop-theme-reviewers,cdupuis,bolsson,akulyk,tgiles Differential Revision: https://phabricator.services.mozilla.com/D279016
…nality r=desktop-theme-reviewers,akulyk,tgiles Differential Revision: https://phabricator.services.mozilla.com/D279962
The hope is that these diagnostic metrics will help us understand why MathML is rendering differently. Differential Revision: https://phabricator.services.mozilla.com/D279927
…window via urlbar results r=urlbar-reviewers,jteow Differential Revision: https://phabricator.services.mozilla.com/D281526
…onmt Similarly with the other UI tests, it failed to select the search shortcut from the slelector. Removed a redundant search bar click. The UI test successfully passed 100x on Firebase ✅ Differential Revision: https://phabricator.services.mozilla.com/D281943
…r=release-managers,pascalc Differential Revision: https://phabricator.services.mozilla.com/D281985
…s,fluent-reviewers,bolsson Differential Revision: https://phabricator.services.mozilla.com/D280304
… weak marking r=sfink The current issue is that we only do this when a weakmap's color changes. This might only happen once at a time when the current mark color is not the one we need to mark the symbol, resulting in the symbol not getting marked. Instead scan atoms zone ephemeron edge sources as part of weak marking since this happens per color. Differential Revision: https://phabricator.services.mozilla.com/D281765
…tests. r=android-reviewers,android-addons-reviewers,007,tcampbell Differential Revision: https://phabricator.services.mozilla.com/D281778
… classes and update tests. r=android-reviewers,007 This also prevents mocking restricted classes: java.lang.System, java.util.Collection, java.util.Map, java.io.File, java.nio.file.Path and subtypes that previously only showed a warning. Differential Revision: https://phabricator.services.mozilla.com/D281779
…ty the same as for cyclic modules r=spidermonkey-reviewers,dminor Module environments are given this special internal property that can hold a reference to the module's namespace object if needed. The property itself is used when module's namespace is imported and then that binding is exported. An import of that uses the binding of the module namespace object in the original object's environment. For cyclic modules this happens by Parser::moduleBody adding a fake declaration for this name, but this is not done for synthetic modules which don't come from parsed JS. The patch adds this name for synthetic modules. Differential Revision: https://phabricator.services.mozilla.com/D281434
… DST. r=spidermonkey-reviewers,dminor Implements the normative changes from <tc39/proposal-temporal#3246>. Changes: - The various `HandleDateTimeTemporal...` methods no longer need to resolve the time zone and instead directly call `GetUTCEpochNanoseconds`. - This allows to remove `DateTimeFormatObject::TIMEZONE_VALUE_SLOT`. - `NewDateTimeFormat` and `NewDateIntervalFormat` use the `"GMT+00:00"` time zone for the plain Temporal types. Differential Revision: https://phabricator.services.mozilla.com/D281613
Automatic update from web-platform-tests Map "slot" web-feature (#56244) -- wpt-commits: 6e3fbc601ae71248639c9e0b76da46e43378e272 wpt-pr: 56244
…stonly Automatic update from web-platform-tests Implement border-shape hit testing So far it's not yet specced if border-shape should be hit-testable outside border-box, so this CL only handles hit-testing inside of it and outside in cases that reach the box with border-shape (e.g. parent node doesn't stop hit-testing children). The spec discussion is at w3c/csswg-drafts#13371 The hit test of PaintLayer will be done in the follow-up and tracked in crbug.com/456675133 Bug: 370041145 Change-Id: I952b3af09d0e3f3c079bdd2938b58e83d44d89a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7510826 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org> Cr-Commit-Position: refs/heads/main@{#1576735} -- wpt-commits: 9233783f017d30c063cebf100de5b4e8084403e7 wpt-pr: 57418
wpt-pr: 57418 wpt-type: metadata
…cestor scroll into view, a=testonly Automatic update from web-platform-tests Correctly propagate scroll margin for ancestor scroll into view This change ensures that when clipping the rect to expose, we only consider the actual rect to make visible, and don't clip away the scroll margin or scroll padding. Since we haven't modified the rect to expose, we can keep the scroll margin as we bubble to ancestor scrollers. Bug: 40876429, 40074749 Change-Id: I8b948fccc0aeee58872ab1632ff20901448b21a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7529476 Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1576737} -- wpt-commits: 0d0862c9b49feba5f50dde6736190efe5020a757 wpt-pr: 57422
wpt-pr: 57422 wpt-type: metadata
…re, a=testonly Automatic update from web-platform-tests Add WPTs for WebXR plane-detection feature Bug: 394636076 Change-Id: I268d51e008fbbe1b894b4c0cf6191e4b73b53050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7524325 Reviewed-by: Brandon Jones <bajones@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#1576754} -- wpt-commits: dcf66d4a89c030461329bf767bfe53ef7bd33e78 wpt-pr: 57424
wpt-pr: 57424 wpt-type: metadata
…changes on an embed, a=testonly Automatic update from web-platform-tests Don't require a LayoutObject when 'src' changes on an <embed> When an <embed> element has no 'src' and no 'type', it represents nothing. When the 'src' would be changed to non-empty in that state there would be no LayoutObject, and thus attach was not triggered for the element. By-pass the check for a LayoutObject in this case. Guarded by the "HTMLEmbedElementRepresentsNothingToActive" flag. Fixed: 479233864 Change-Id: If5bf5cc2684e146dfc56dda02f12e930a134a717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7524670 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1576496} -- wpt-commits: 804edccb7af90861240f2cada15f9c84d8702bff wpt-pr: 57409
…ng it r=urlbar-reviewers,mbeier" for causing bc failures on browser_searchModeSwitcher_searchMode.js This reverts commit 30c5dc7.
…wers,valentin" on request This reverts commit 665d7ba.
…l10n/android-l10n CLOSED TREE" for causing run bustage This reverts commit 9427aa8.
…x-style-system-reviewers,emilio Differential Revision: https://phabricator.services.mozilla.com/D281721
…Get Started". r=ip-protection-reviewers,hjones,sstreich Signing in will no longer enroll a user, only clicking "Get Started" in the panel or in settings will trigger enrollment. - Refactors `IPPEnrollAndEntitleManager.maybeEnrollAndEntitle()` to only handle the enrollment flow. - Adds an `IPPEnrollAndEntitleManager.updateEntitlement()` method for when only the entitlement should be checked. - Removes `IPProtectionService.signInFlow`. - Adds and `IPProtectionPanel.enroll()` methods for enrolling a user in a panels window. - Set the `IPProtectionService` state to `READY` while the enrollment is finishing so a user can immediately interact with the VPN. - Updates tests that involve enrollment. Differential Revision: https://phabricator.services.mozilla.com/D281562
…=masayuki This avoids tripping on the shadow tree mutation. Move the NodeNeedsTextChange check earlier since it is cheaper. Differential Revision: https://phabricator.services.mozilla.com/D281933
…iewers,reemhamz,nina-py Adds four new unified Glean metrics to replace per-widget telemetry: - widgets_impression: Records when any widget is visible - widgets_user_event: Records user interactions with any widget - widgets_enabled: Records when widgets are enabled/disabled - widgets_error: Records when widgets encounter an error Differential Revision: https://phabricator.services.mozilla.com/D281043
…e to newtab_visit_id. r=home-newtab-reviewers,nbarrett The handlePromoCardUserEvent and handleWidgetsUserEvent methods were incorrectly accessing session.visit_id, which doesn't exist. The correct property is session.session_id. This bug caused these telemetry events to send undefined for the newtab_visit_id field. Differential Revision: https://phabricator.services.mozilla.com/D281044
…e kebab-case. r=home-newtab-reviewers,reemhamz Differential Revision: https://phabricator.services.mozilla.com/D281045
…ewtab-reviewers,reemhamz,nina-py Implements scalable widget telemetry by adding unified metrics that work for all widgets, replacing per-widget metrics. This commit focuses on the Lists widget while maintaining backward compatibility. Differential Revision: https://phabricator.services.mozilla.com/D281046
…ome-newtab-reviewers,reemhamz,nina-py Implements scalable widget telemetry by adding unified metrics that work for all widgets, replacing per-widget metrics. This commit focuses on the FocusTimer widget while maintaining backward compatibility. Differential Revision: https://phabricator.services.mozilla.com/D281047
…nel-list. r=home-newtab-reviewers,reemhamz,nina-py Refactors Weather.jsx to use panel-list for context menu instead of LinkMenu, matching the pattern used by Lists and FocusTimer widgets. This simplifies the context menu implementation and prepares for unified telemetry integration. Differential Revision: https://phabricator.services.mozilla.com/D281048
…newtab-reviewers,reemhamz,nina-py Implements unified telemetry events for the Weather widget following the pattern established in Lists and FocusTimer widgets. Maintains backward compatibility by dual-emitting both old and new telemetry events. Differential Revision: https://phabricator.services.mozilla.com/D281049
…ome-newtab-reviewers,nina-py,reemhamz Adds widgets_container_action event to track user interactions with widget container controls (hide all widgets and toggle maximize/minimize buttons). Differential Revision: https://phabricator.services.mozilla.com/D281050
…b-reviewers,maxx,nina-py Differential Revision: https://phabricator.services.mozilla.com/D281565
This doesn't fix all the orphaned clip-chains from bug 2011998, but it fixes some of the easy ones. When we switch transforms or so, right now we eagerly create the clipchain even if we don't end up using it, and it's rather easy to avoid doing so. There are some others which generally come from SwitchItem() calls, which are a bit harder to deal with because we just stash the clipchain id in the DL builder. Differential Revision: https://phabricator.services.mozilla.com/D281324
…ewers,teoxoy Differential Revision: https://phabricator.services.mozilla.com/D282062
…gpu-reviewers,teoxoy" for causing bustage @ AccessibleTableCell.h.stub This reverts commit 2292bfc.
…34, Bug 2013133, Bug 2012838, Bug 2012824, Bug 2010597 - Add telemetry for Weather Forecast widget. r=home-newtab-reviewers,maxx,nina-py" for causing newtab failure This reverts commit 49e2edf. Revert "Bug 2012821 - Add unified telemetry for widget container actions. r=home-newtab-reviewers,nina-py,reemhamz" This reverts commit 6a74930. Revert "Bug 2013138 - Add unified widget telemetry to Weather widget. r=home-newtab-reviewers,reemhamz,nina-py" This reverts commit 1f0b203. Revert "Bug 2013136 - Migrate Weather widget context menu from LinkMenu to panel-list. r=home-newtab-reviewers,reemhamz,nina-py" This reverts commit 64f84bd. Revert "Bug 2013134 - Add unified widget telemetry for FocusTimer widget. r=home-newtab-reviewers,reemhamz,nina-py" This reverts commit d6be553. Revert "Bug 2013133 - Add unified widget telemetry for Lists widget. r=home-newtab-reviewers,reemhamz,nina-py" This reverts commit e720294. Revert "Bug 2012838 - Fix data-eventSource attributes in ContentSection to use kebab-case. r=home-newtab-reviewers,reemhamz" This reverts commit f5892e5. Revert "Bug 2012824 - Update widget telemetry events to pass the correct value to newtab_visit_id. r=home-newtab-reviewers,nbarrett" This reverts commit 067acc9. Revert "Bug 2010597 - Add unified widget telemetry metrics. r=home-newtab-reviewers,reemhamz,nina-py" This reverts commit a7506b3.
…eviewers,android-reviewers,bhearsum,sfamisa" for causing run failure This reverts commit 6386373.
…efox-style-system-reviewers,xpcom-reviewers,layout-reviewers,dshin,nika I looked at this because in bug 2014331 I need to mark more pseudos as element-backed, and it's kinda silly the state our setup is in right now. This is all a somewhat historical mess, because in the old style system pseudo-elements were just atoms, and we had that different types of atom setup. The source of truth for these right now lives in a header macro file, which isn't very flexible. But now we have PseudoStyleType which represents both pseudos and anon boxes, and is similar to the rust side PseudoElement enum. Plus, the ::-moz-tree pseudo-elements are defined as anon boxes which doesn't make any sense, so move them to pseudo-elements while at it. Unify this in a similar way we treat CSS properties: Source of truth is in pseudo_elements.toml / anon_boxes.toml, and we generate Rust and C++ as needed. This allows removing the nsStaticAtom subclass thing from XPCOM, too. This avoids some nasty duplication around which pseudos are pref-gated and what not as well. Differential Revision: https://phabricator.services.mozilla.com/D282076
…layout-reviewers,dholbert They are, in fact, real elements inside the select shadow tree. This makes this code-path behave properly, since we otherwise assume that pseudo-elements are NAC: https://searchfox.org/firefox-main/rev/286e75a82e5c489d020d18121674809ebf114ae4/layout/generic/nsIFrame.cpp#11312-11316 Differential Revision: https://phabricator.services.mozilla.com/D282078
…e expected parent. r=layout-reviewers,dshin In the regressing bug, I made the assumption that given how FindHTMLData for <select> works, a combobox <select> would always have an nsComboboxControlFrame. Turns out this is not necessarily true. If the select is the root element, we create a regular block for it: https://searchfox.org/firefox-main/rev/286e75a82e5c489d020d18121674809ebf114ae4/layout/base/nsCSSFrameConstructor.cpp#2529-2537 I'm slightly surprised other code doesn't trip into asserts with such stuff (e.g., an <iframe> might not have an nsSubDocumentFrame, etc). For now restore the pre-regression behavior and just refuse to create the broken frame tree structure in those cases. Differential Revision: https://phabricator.services.mozilla.com/D282089
This is mainly just adding some flushing and forcing rebindings of framebuffer state that should not be necessary, but seemingly tricks the NVIDIA driver into doing the right thing. Differential Revision: https://phabricator.services.mozilla.com/D281872
… have the expected parent. r=layout-reviewers,dshin" for causing backout conflict @ nsCSSFrameConstructor.cpp with Bug 2014922 This reverts commit c074a9d.
…cked. r=layout-reviewers,dholbert" for causing backout conflict @ pseudo_elements.toml with Bug 2014922 This reverts commit d828cc1.
…s. r=firefox-style-system-reviewers,xpcom-reviewers,layout-reviewers,dshin,nika" for causing bustage @ ElementAnimationData.h This reverts commit c70290c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )