Skip to content

fix(FastLED_Functions): remove seam (#81) #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(FastLED_Functions): remove seam (#81) #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68171be
fix(FastLED_Functions): remove seam (#81)
sutaburosu Jan 17, 2021
c148099
fix(fillnoise8): remove seams on non-square matrices
sutaburosu Jan 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions examples/FastLed_Functions/FastLed_Functions.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ uint16_t speed = 20; // a nice starting speed, mixes well with a scale of 100
uint16_t scale = 31;

// This is the array that we keep our computed noise values in
uint8_t noise[kMatrixWidth][kMatrixHeight];
const uint16_t kMatrixLongestSide = (kMatrixWidth > kMatrixHeight) ? kMatrixWidth : kMatrixHeight;
uint8_t noise[kMatrixLongestSide][kMatrixLongestSide];

void setup() {
// Enable printing FPS count information
Expand Down Expand Up @@ -89,9 +90,9 @@ void setup() {

// Fill the x/y array of 8-bit noise values using the inoise8 function.
void fillnoise8() {
for(int i = 0; i < kMatrixWidth; i++) {
for(int i = 0; i < kMatrixLongestSide; i++) {
int ioffset = scale * i;
for(int j = 0; j < kMatrixHeight; j++) {
for(int j = 0; j < kMatrixLongestSide; j++) {
int joffset = scale * j;
noise[i][j] = inoise8(x + ioffset,y + joffset,z);
}
Expand Down
16 changes: 8 additions & 8 deletions examples/FastLed_Panel_Plus_Apa102/FastLed_Panel_Plus_Apa102.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,21 +85,21 @@ uint16_t speed = 1; // almost looks like a painting, moves very slowly
uint16_t scale = 31;

#if (ENABLE_APA102_REFRESH == 1)
#define MAX_DIMENSION_APA ((kApaMatrixWidth>kApaMatrixHeight) ? kApaMatrixWidth : kApaMatrixHeight)
const uint16_t kApaMatrixLongestSide = (kApaMatrixWidth>kApaMatrixHeight) ? kApaMatrixWidth : kApaMatrixHeight;
#else
#define MAX_DIMENSION_APA 0
const uint16_t kApaMatrixLongestSide = 0;
#endif

#if (ENABLE_HUB75_REFRESH == 1)
#define MAX_DIMENSION_PANEL ((kMatrixWidth>kMatrixHeight) ? kMatrixWidth : kMatrixHeight)
const uint16_t kMatrixLongestSide = (kMatrixWidth > kMatrixHeight) ? kMatrixWidth : kMatrixHeight;
#else
#define MAX_DIMENSION_PANEL 0
const uint16_t kMatrixLongestSide = 0;
#endif

#define MAX_DIMENSION_OVERALL ((MAX_DIMENSION_APA>MAX_DIMENSION_PANEL) ? MAX_DIMENSION_APA : MAX_DIMENSION_PANEL)
const uint16_t kLongestSideOverall = (kApaMatrixLongestSide > kMatrixLongestSide) ? kApaMatrixLongestSide : kMatrixLongestSide;

// This is the array that we keep our computed noise values in
uint8_t noise[MAX_DIMENSION_OVERALL][MAX_DIMENSION_OVERALL];
uint8_t noise[kLongestSideOverall][kLongestSideOverall];

uint16_t XY(uint8_t x, uint8_t y) {
return kApaMatrixWidth * y + x;
Expand Down Expand Up @@ -176,9 +176,9 @@ void setup() {

// Fill the x/y array of 8-bit noise values using the inoise8 function.
void fillnoise8() {
for(int i = 0; i < MAX_DIMENSION_OVERALL; i++) {
for(int i = 0; i < kLongestSideOverall; i++) {
int ioffset = scale * i;
for(int j = 0; j < MAX_DIMENSION_OVERALL; j++) {
for(int j = 0; j < kLongestSideOverall; j++) {
int joffset = scale * j;
noise[i][j] = inoise8(x + ioffset,y + joffset,z);
}
Expand Down
7 changes: 4 additions & 3 deletions examples/MultipleTextLayersGfx/MultipleTextLayersGfx.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,13 +161,14 @@ uint16_t speed = 10; // a nice starting speed, mixes well with a scale of 100
uint16_t scale = 31;

// This is the array that we keep our computed noise values in
uint8_t noise[kMatrixWidth][kMatrixHeight];
const uint16_t kMatrixLongestSide = (kMatrixWidth > kMatrixHeight) ? kMatrixWidth : kMatrixHeight;
uint8_t noise[kMatrixLongestSide][kMatrixLongestSide];

// Fill the x/y array of 8-bit noise values using the inoise8 function.
void fillnoise8() {
for(int i = 0; i < kMatrixWidth; i++) {
for(int i = 0; i < kMatrixLongestSide; i++) {
int ioffset = scale * i;
for(int j = 0; j < kMatrixHeight; j++) {
for(int j = 0; j < kMatrixLongestSide; j++) {
int joffset = scale * j;
noise[i][j] = inoise8(x + ioffset,y + joffset,z);
}
Expand Down