Fixes to MatrixEsp32Hub75Refresh*Impl.h required for C++20 compilation. #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i2s_parallel_config_t is initialized with the C99/GNU designated member initializers and old-style positional initializations. As of C++20, mixing like this is no longer allowed. The error is pretty self-explanatory: src/MatrixEsp32Hub75Refresh_NT_Impl.h:449:9: error: either all initializer clauses should be designated or none of them should be Tested working withe ESP32 HUB75 Matrix in NightDriverLED/Mesmerizer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i2s_parallel_config_t is initialized with the C99/GNU designated member
initializers and old-style positional initializations. As of C++20, mixing
like this is no longer allowed.
The error is pretty self-explanatory:
src/MatrixEsp32Hub75Refresh_NT_Impl.h:449:9: error: either all initializer clauses should be designated or none of them should be
Tested working withe ESP32 HUB75 Matrix in NightDriverLED/Mesmerizer.