-
Notifications
You must be signed in to change notification settings - Fork 4
Writing support, error handling and simplifications #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
first implementation of writer
…avoid holding all the points in memory at once?
The approach I have taken with the writer is that I want it to keep as few points in memory at any one time as possible (this is a constraint I added due to my current project where I would like to do multiple files in parallel). So I have made two node insertions strategies:
Both strategies writes a node to file as soon as it is filled up. I think a whole new writing strategy must be written and the constraint of not holding full nodes in memory must be scrapped. |
Thanks for your work on copc-rs! I'm fine with merging a non-optimal writer implementation. The only nitpick is that bumping to version 1.0 is too early. So feel free to un-draft your PR, if it's working for your use case. |
Hi!
I realized I should probably have filed draft PR on my work on a writer and some other stuff.
Done:
WIP:
I have implemented a writer that writes copc files (not thoroughly tested) #7
BUT the writer does not write "good" files.
By that I mean that full resolution spatial queries are good, but limited resolution queries return bad results.
This is because the point distribution in a level does not represent the distribution of the entire cloud.
This means that viewing the file in a copc viewer will not look right.
I stopped working on the writer 3months ago as all I need for my current project are copc files with good full resolution queries.
I would like to make a proper writer when I find time, but don't know when that is.
Help is appreciated