Open
Conversation
This brings more in line with the go impl; exec manager tracks if it has exited and won't try to send stuff if it has, evaluators can close themselves at which point they will throw sensible errors if you try to use them.
Contributor
|
Looks like we've got tests hanging: The latter three are test cases where Pkl itself will error and exit non-zero. The fact that they're succeeding means an error must be being thrown (as expected), but it looks like this change is causing something to hang open. |
Contributor
Author
|
ah, damn. will work on it. nice tests! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings more in line with the go impl; exec manager tracks if it has exited and won't try to send stuff if it has, evaluators can close themselves at which point they will throw sensible errors if you try to use them.