Verify output of invoking pkl in action test#43
Draft
jasongwartz wants to merge 1 commit intomainfrom
Draft
Conversation
jasongwartz
force-pushed
the
verify-pkl-invoke-output
branch
from
2b9ff65 to
7478dec
Compare
StefMa
reviewed
Aug 21, 2024
| matrix: | ||
| # Right now macos-13 is amd64 while macos-14 is aarch64 (M1) | ||
| os: [ubuntu-latest, macos-13, macos-14, windows-latest] | ||
| pkl_version: [0.26.0, 0.26.1, 0.26.2, 0.26.3] |
Contributor
There was a problem hiding this comment.
Do we really need/want a matrix test for each and every single pkl version? 🤔
I have the feeling that is a bit overkill..
Contributor
Author
There was a problem hiding this comment.
Haha probably not, I added it in this (still in draft!) PR to make sure the checking of version strings was working (properly interpolated, not accidentally comparing to a hard-coded value, say).
I will probably leave in the matrix but with only one array element - in case Pkl changes their download mechanism in the future, and we want to test new behaviour for downloading from both old methods and new.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.