pkpdocs#1367 A11Y - Search component missing description text #1387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
israelcefrin
force-pushed
the
i1367_search_component
branch
from
7148064 to
f100b2f
Compare
israelcefrin
force-pushed
the
i1367_search_component
branch
from
f100b2f to
3015182
Compare
_includes/hub/hero.html
Outdated
| {% endif %} | ||
| <script async src="https://cse.google.com/cse.js?cx=342127f3c8880483d"> | ||
| </script> | ||
| <h2 class="-screenReader" id="search">Search PKP documentation</h2> |
There was a problem hiding this comment.
Hi @israelcefrin, we typically avoid putting the text labels directly into the templates - could you instead add the text as a new entry in _data/site.yml, then reference it in the two templates here, e.g. <h2 class="-screenReader" id="search">{{ site.data.site.searchHeading }}</h2>
|
Hi @israelcefrin, one comment for review - thanks! |
…bel to site.yml file
|
Hello @kaitlinnewson , thanks for reviewing it. I've added the text label to the yml file and referenced it in the template as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the missing text description for the search component adding a hidden heading level 2 (h2) to the Google search component since it doesn't allow us to add an
aria-labelparameter.Issue: #1367