pkp/pkp-lib#10929 Temporary fix for Production Editor's file upload issues

[taslangraham]

For #10929

[taslangraham]

Not sure if this is the best way to check for a specific role. Open to suggestions

[Vitaliy-1]

I think the best way would be to check the access to the submission stage through the user group stage table

[Vitaliy-1]

Forgot to mention that OPS might require different treatment - in 3.5 stage ID has only value 5 there, submission stage was removed.

[taslangraham]

@Vitaliy-1 Thanks for the review. I've made the updates based on your suggestions.

Also, given that OPS does not have Production Editor group, and production stage (stage ID 5), I've added app level implementation for the SubmissionController::add method in OPS. PR can be found here.

[Vitaliy-1]

Sorry for the late reply!

The part of code that checks user roles and automatically assigns author role if necessary is here: https://github.com/pkp/pkp-lib/blob/main/pages/submission/PKPSubmissionHandler.php#L615

Thus, it makes senes to move the check there.
Moreover, I don't know what was the initial idea behind that part. In my opinion, it makes sense to check if user has access to the submission stage in general, and if not, assign an author role. That applies, for production editors, which are managers, copyeditors, layout editors, reviewers... and custom user groups.

Also, we might want to exclude user groups without access to submission stage from from the list here: https://github.com/pkp/pkp-lib/blob/main/classes/components/forms/submission/StartSubmission.php#L159

[taslangraham]

Thanks @Vitaliy-1, I've made updates based on your suggestions:

1. Move checks and group assignment to https://github.com/pkp/pkp-lib/blob/main/pages/submission/PKPSubmissionHandler.php#L615
   • Assign user to Author role once user doesn't have access to submission stage
2. Exclude user groups without access to submission stage from list of "Submit as" options
3. Keep original behaviour for https://github.com/pkp/pkp-lib/blob/main/pages/submission/PKPSubmissionHandler.php#L615 in OPS (PR)

Take a look and let me know if it makes sense