pkp/pkp-lib#10359 record dateConsidered for automatic Acknoledment #11284
+30
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jardakotesovec
commented
Apr 16, 2025
| $newReviewData['considered'] = $reviewAssignment->getConsidered() === ReviewAssignment::REVIEW_ASSIGNMENT_NEW | ||
| // if the review assignment had been unconsidered or only viewed but not considered, update the flag. | ||
| $newReviewData['considered'] = ($reviewAssignment->getConsidered() === ReviewAssignment::REVIEW_ASSIGNMENT_NEW || | ||
| $reviewAssignment->getConsidered() === ReviewAssignment::REVIEW_ASSIGNMENT_VIEWED) | ||
| ? ReviewAssignment::REVIEW_ASSIGNMENT_CONSIDERED |
There was a problem hiding this comment.
Somewhat related problem while testing. I noticed that I was getting REVIEW_ASSIGNMENT_RECONSIDERED, even after simple confirmation. Thats because we have also the REVIEW_ASSIGNMENT_VIEWED now.
jardakotesovec
commented
Apr 16, 2025
| if(!empty($updateData)) { | ||
| Repo::reviewAssignment()->edit($reviewAssignment, $updateData); | ||
| } | ||
|
|
There was a problem hiding this comment.
This is now aligned with the ThankReviewer Form
jardakotesovec
commented
Apr 16, 2025
| if(!$reviewAssignment->getDateConsidered()) { | ||
| // set the date when the editor confirms the review | ||
| $newData['dateConsidered'] = Core::getCurrentDate(); | ||
| } |
There was a problem hiding this comment.
I noticed while testing, that after thanking it overrode the dateConsidered to currentDate. So also moved it behind condition.
jardakotesovec
commented
Apr 16, 2025
| @@ -149,13 +149,16 @@ public function execute(...$functionArgs) | |||
| // update the ReviewAssignment with the acknowledged date | |||
| $newData = ['dateAcknowledged' => Core::getCurrentDate()]; | |||
| if (!in_array($reviewAssignment->getConsidered(), [ReviewAssignment::REVIEW_ASSIGNMENT_CONSIDERED, ReviewAssignment::REVIEW_ASSIGNMENT_RECONSIDERED])) { | |||
There was a problem hiding this comment.
Not sure when this could happen... because in UI its needs to be confirmed, before thanking. But since its here I followed same logic for the NotifyReviewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.