pkp/pkp-lib#11171 Config data reset for writing at installation #11295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
touhidurabir
commented
Apr 18, 2025
| @@ -949,8 +951,11 @@ public function checkPhpVersion() | |||
| */ | |||
| public function updateRorRegistryDataset(): bool | |||
| { | |||
| PKPApplication::upgrade(); | |||
There was a problem hiding this comment.
Had to add this as below class calls internally PKPApplication::getHttpClient which try to retrieve the version information but we register the version details at the very end of installation phase and without this get null which raise exception .
This is due to the add of config reset after the config file update at the install phase which update the config installed to On which in return cause application to try to get version data before it got inserted and cause error as not available yet .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #11171