-
Notifications
You must be signed in to change notification settings - Fork 152
♻️ Change Currency
to class
#3888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
greymistcube
wants to merge
6
commits into
planetarium:main
Choose a base branch
from
greymistcube:refactor/currency-to-class
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
♻️ Change Currency
to class
#3888
greymistcube
wants to merge
6
commits into
planetarium:main
from
greymistcube:refactor/currency-to-class
+214
−357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s2quake
reviewed
Jul 22, 2024
s2quake
reviewed
Jul 22, 2024
s2quake
reviewed
Jul 22, 2024
s2quake
reviewed
Jul 22, 2024
ca8dc5d
to
14f9a9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currency
structure is too complicated to be used as astruct
.Currency
as astruct
stands at 72 bytes, which is too large.default
forCurrency
is an invalid value where it can break things down the line.Also I've cleaned up most constructors to have consistent validation logic for creating a new
Currency
by funneling them to a singleprivate
constructor. However, there still is a loophole where an invalid currency can be created through JSON deserialization. This is due to the JSON format ofCurrency
having a yet another scheme that is different from the one forIValue
or forHash
. 🙄