Add MariaDB compatibility workaround for Arch Linux #1138
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
On Arch Linux, the
mysqlclient binary is provided by MariaDB, since MySQL has been dropped from the official repositories.As a result, running
mysql --versionreturns a MariaDB version string and a deprecation warning:which causes the function
MySQLClientPathininternal/cmdutil/cmdutil.goto throw an error:when it attempts to parse the version output.
This PR introduces a compatibility workaround.
If the version string contains "MariaDB" it just returns the path with
mysql_native_passwordas the auth method, rather than erroring out.This is a bandaid solution to allow Arch users (and other distros using MariaDB as a drop in replacement) to proceed without breaking functionality.
In the long term, it may make sense to support MariaDB explicitly instead of relying on this fallback.