fix: remove broken tests based on jetty-runner #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rroesch1
commented
Feb 5, 2025
•
rroesch1
commented
- tests based on jetty-runner do not work because the jetty-runner JAR contains invalid Java SPI services config files
- due to these invalid files Jetty 11.0.20+ is unable to properly initialize itself itself
- This change removes all tests based on jetty-runner and bumps the Jetty version to 11.0.24
- There are already jobs using the Jetty Maven plugin to launch a testing instance + run all tests
* tests based on jetty-runner do not work because the jetty-runner JAR contains invalid Java SPI services config files * due to these invalid files Jetty 11.0.20+ is unable to properly initialize itself itself * This change removes all tests based on jetty-runner and bumps the Jetty version to 11.0.24 * There are already jobs using the Jetty Maven plugin to launch a testing instance + run all tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.