feat(charts): add "common.hostAliases" helper in common #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akafazov
force-pushed
the
feat/global-hostAliases
branch
2 times, most recently
from
18e49a7 to
e04d76d
Compare
Contributor
|
I'd suggest to change this PR to:
This would allow us to only enable the hostaliases for the local setup while keeping the ability to overwrite it if necessay. |
akafazov
force-pushed
the
feat/global-hostAliases
branch
2 times, most recently
from
51f26fc to
4254ce0
Compare
On-behalf-of: @SAP [email protected] Signed-off-by: Angel Kafazov <[email protected]>
On-behalf-of: @SAP [email protected] Signed-off-by: Angel Kafazov <[email protected]>
…eld. Adjust helper accordingly. On-behalf-of: @SAP [email protected] Signed-off-by: Angel Kafazov <[email protected]>
On-behalf-of: @SAP [email protected] Signed-off-by: Angel Kafazov <[email protected]>
…le entries On-behalf-of: @SAP [email protected] Signed-off-by: Angel Kafazov <[email protected]>
On-behalf-of: @SAP [email protected] Signed-off-by: Angel Kafazov <[email protected]>
akafazov
force-pushed
the
feat/global-hostAliases
branch
from
3c86cd0 to
7661bfc
Compare
nexus49
requested changes
Nov 17, 2025
On-behalf-of: @SAP [email protected] Signed-off-by: Angel Kafazov <[email protected]>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
On-behalf-of: @SAP [email protected] Signed-off-by: Angel Kafazov <[email protected]>
On-behalf-of: @SAP [email protected] Signed-off-by: Angel Kafazov <[email protected]>
nexus49
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces "common.hostAliases" helper function in
commonchart, to enable configuration of hostAliases in charts' deployments.Follow up to #432 (comment)