Fix unhandled errors on custom connection errors #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes crashes due to unhandled errors if more than one
packet with unknown correlation ID are received in succession. The
connection pool attaches an error handler via
`connection.once('error', ...)` which detaches the error handler after
being invoked once. Further emitted errors will be handled as uncaught
exceptions and exit the program. Also, the socket is not closed when
emitting this error and keeps listening for incoming messages. By
destroying the socket and providing the appropriate error we prevent
the socket from handling any more packets, thus preventing uncaught
exceptions.
Furthermore, by providing the error as parameter to the socket
destruction we stay within the normal socket lifecycle and all
clean up on socket closure is done, which was previously skipped
entirely.
on-behalf-of: @SAP [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses crashes caused by unhandled errors that occur when multiple packets with unknown correlation IDs are received consecutively. The connection pool attaches an error handler via
connection.once('error', ...), which detaches the error handler after it has been invoked once. This error handler does not close the connection/socket. Further emitted errors will be handled as uncaught exceptions and will cause the program to exit, as the socket remains open when emitting this error and continues to listen for incoming messages. By destroying the socket and providing the appropriate error, we prevent the socket from handling any more packets, thus preventing uncaught exceptions.Furthermore, by providing the error as a parameter to the socket destruction, we remain within the normal socket lifecycle, and all cleanup on socket closure is performed, which was previously also skipped entirely.
on-behalf-of: @SAP [email protected]