Refactor ListReport to TS, share props #5161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
apata
force-pushed
the
saved-segments/list-to-tsx
branch
from
f00741f to
3a286a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR refactors ListReport to Typescript and unifies its props with BreakdownModal. No functional changes.
This is in anticipation of changing how metrics are determined in both ListReport and BreakdownModal.
Refactoring how metrics are determined is needed because the BE knows better which metrics are possible for each situation. Especially if some of the filters are wrapped inside a segment.
Tests
Changelog
Documentation
Dark mode