Change redirects from external to internal where possible #5331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoldar
commented
Apr 15, 2025
| @@ -185,8 +185,8 @@ defmodule PlausibleWeb.Live.Verification do | |||
| end | |||
|
|
|||
| defp redirect_to_stats(socket) do | |||
| stats_url = Routes.stats_url(PlausibleWeb.Endpoint, :stats, socket.assigns.domain, []) | |||
There was a problem hiding this comment.
Was there a particular reason for using _url instead of _path helper here? 🤔 \cc @aerosol
|
macobo
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We've been using redirect(external: ...) for all paths containing domain because in the past, Phoenix's redirect was overzealous when sanitizing the URL, effectively rejecting URL-encoded UTF8 characters (starting with %). Current version of phoenix has that sanitization relaxed and relying on external redirects is no longer necessary.