fix(docker/entrypoint.sh): Use exec to replace the shell
#109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be done to allow the container to properly react to unix signals (e.g., `SIGTERM`). Currently, PID 1 is `sh` which is executing the script until the `playit` binary stops. When the pod is stopped, e.g., using `docker stop` or in Kubernetes, when the pod is being deleted, the container runtime sends a `SIGTERM` to PID 1 to allow for graceful termination. `sh` however, does not handle signals, which results in the container running indefinitely until the container runtime sends a `SIGKILL`.
|
Thank you, I'll get this into the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be done to allow the container to properly react to unix signals (e.g.,
SIGTERM).Currently, PID 1 is
shwhich is executing the script until theplayitbinary stops. When the pod is stopped, e.g., usingdocker stopor in Kubernetes, when the pod is being deleted, the container runtime sends aSIGTERMto PID 1 to allow for graceful termination.shhowever, does not handle signals, which results in the container running indefinitely until the container runtime sends aSIGKILL.