Cgo fixes

[izissise]

Hello this is two simple fix that make go_rules work better in cgo mode

Add _module parameter generated by please_go

see #164 (comment)

Remove -Wno-error, include PKG_DIR

Fix #149

cc_library include . (-I .) but cgo put all files in PKG_DIR

[Tatskaari]

Hey! Thanks for the PR. I think we should pass the _module arg to the underlying go_library call so that gets plumed through?

[izissise]

Done

[Tatskaari]

Hey! Sorry I missed the removal of -Wno-error. Why did you want to change this behavior? We're compiling a lot of generated code here and I'm a little worried it's going to end up failing fairly regularly.

[izissise]

Actually I read the issue linked and agreed with the thinking, since they are about the same lines, I though to get two birds with one stone.

…

On Fri, Oct 27, 2023, 17:18 Jonathan Poole ***@***.***> wrote: Hey! Sorry I missed the removal of -Wno-error. Why should we change this behavior? We're compiling a lot of generated code here and I'm a little worried it's going to end up failing fairly regularly? — Reply to this email directly, view it on GitHub <#169 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQB2YFSBH3I4FVSIAPCQTDYBPGFRAVCNFSM6AAAAAA6RKHNYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBTGA4TGMBTHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[peterebden]

Makes sense. The removal of -Wno-error is really a breaking change though so maybe we should be careful with it - I'm not sure we should just add it to a patch release.