Fix BASE_URL support #760
Open
Fix BASE_URL support #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredledvina
force-pushed
the
fix/base-url-issue-649
branch
from
4ed2bd5 to
80d5c33
Compare
Previously BASE_URL only applied when base_url was empty in the database, leaving users with incorrect values unable to recover without manual database editing. Now BASE_URL environment variable always overrides the database value when set, providing a recovery path for misconfigured deployments.
Flask routes are registered at paths like /setup, but when BASE_URL is configured, requests arrive as /huntarr/setup. Added BaseURLMiddleware to strip the BASE_URL prefix from request paths before Flask routing occurs, allowing routes to be found correctly. Also normalized BASE_URL handling with helper functions to consistently handle edge cases like '/', whitespace, and multiple slashes.
Updated all redirect calls to prepend BASE_URL when redirecting to setup, login, and user pages. This ensures redirects work correctly when the application is deployed under a reverse proxy subpath. Fixes redirect loops that occurred when BASE_URL was configured.
Updated cycle countdown timer to use window.HUNTARR_BASE_URL when constructing API URLs, ensuring API calls work correctly when BASE_URL is configured for reverse proxy deployments.
jaredledvina
force-pushed
the
fix/base-url-issue-649
branch
from
7764c1b to
8276422
Compare
Signed-off-by: Jared Ledvina <[email protected]>
Signed-off-by: Jared Ledvina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #649, #732
Related to #130
This PR updates the overall logic around the
BASE_URLparameter. I've built Hunter off this branch and am running it. So far, it looks like this will completely restore the BASE_URL support so that it works as intended. See the commits for a break down for each of the bits.I've locally tested this change with
BASE_URLset tohuntarr, changing tohuntarrtesting, and then to''and confirmed that in all 3 cases it works and adjusts the base path each time. I also dropped the env variable and confirmed that the DB saved the latest config and used that appropriately.