[XELP] use forked versions for custom support and all the fixes. #1
Conversation
There was a problem hiding this comment.
Pull request overview
This PR switches the project to use forked versions of dependencies (specifically brighterscript) to support custom fixes and features. The main changes include:
- Adding a new formatting option
insertSpaceBetweenFunctionAssignmentsto control spacing around assignment operators in function parameters - Improving indentation logic to handle complex nested structures like arrays in conditional statements and object literals after array access
- Adding support for new token kinds (
QuestionLeftParen,ReplacementIdentifier,AtStop) - Preserving formatting for return arrays on the same line
- Special handling for standalone closing brackets
- Adding a GitHub Actions workflow for automated shadow releases
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json, package-lock.json | Updated dependency to use forked brighterscript version from GitHub |
| src/formatters/MultiLineItemFormatter.ts | Added isReturnArrayOnSameLine method to preserve return array formatting |
| src/formatters/InteriorWhitespaceFormatter.ts | Implemented insertSpaceBetweenFunctionAssignments option and added special handling for new token kinds |
| src/formatters/InteriorWhitespaceFormatter.spec.ts | Added comprehensive test coverage for the new function assignment formatting feature |
| src/formatters/IndentFormatter.ts | Refactored indentation tracking to use IndentState interface and improved logic for suppressing structure indentation |
| src/formatters/IndentFormatter.spec.ts | Added test cases for complex indentation scenarios including else-if blocks and nested structures |
| src/constants.ts | Added new token kinds to various constant arrays for proper formatting support |
| src/FormattingOptions.ts | Added insertSpaceBetweenFunctionAssignments option with default value of true |
| bsfmt.schema.json | Updated JSON schema with new formatting option documentation |
| README.md | Updated documentation to describe the new formatting option |
| .github/workflows/xelp_shadow_release.yml | New workflow for automated shadow releases with custom versioning scheme |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 12 changed files in this pull request and generated 10 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ljunkie
force-pushed
the
rob/xelp-main
branch
from
1ebce19 to
13f4c76
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 12 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ljunkie
force-pushed
the
rob/xelp-main
branch
2 times, most recently
from
ace5d44 to
0bce280
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 13 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 14 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Prevent `activeIndentorsOnThisLine` from becoming negative
- Allow block enders (e.g. `end if`, `}`) to trigger outdent even when followed by a colon.
- Fixes issue where constructs like `} : {` or `end if : if` caused incorrect double indentation.
ljunkie
force-pushed
the
rob/xelp-main
branch
from
13c1870 to
66edc03
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 14 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ljunkie
force-pushed
the
rob/xelp-main
branch
from
c6003ff to
45061df
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 19 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
IndentFormatter: continue in loops, double un-indent, EOF after outdent, next followed by colon, #end if followed by colon, end interface/end enum. InteriorWhitespaceFormatter: ReplacementIdentifier, anonymous functions, parameter assignment spacing, sub edge cases (EOF, invalid tokens).
ljunkie
force-pushed
the
rob/xelp-main
branch
from
45061df to
680026c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 20 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 20 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ljunkie
force-pushed
the
rob/xelp-main
branch
from
4a9c867 to
7ea5f8b
Compare
1 participant
No description provided.