feat: movement-based M3/drg button (hold = scroll, tap = m3)#10
Open
dann-huang wants to merge 3 commits into
Open
feat: movement-based M3/drg button (hold = scroll, tap = m3)#10dann-huang wants to merge 3 commits into
dann-huang wants to merge 3 commits into
Conversation
Owner
|
Several build failures. Will revisit this later |
This reverts commit bb305ed.
Author
|
Just as a point of reference I made temp changes to run gh action workflows on this branch. Both seem to finish successfully. There are some warnings, but seemingly no errors nor size issues. I didn't actually test the build artifacts since I only have an adept on hand, but gh runners seem somewhat happy with the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello. Big fan, used your firmware for around half a year.
This PR introduces 2 keycodes.
better_dragscroll_momentarywhen held.motivation
I use the ploopy adept and found 6 face btns surprisingly not abundant. I also really like drag scroll, but dedicating an entire button feels slightly wasteful since "click" on scroll isn't meaningful. On the flip side, I rarely use drag with m3. Hence this addition.
how it works
re: drag scroll with layer
I did notice that drag scroll with (another) layer was added in the interim. That seems like it would solve the same problem via a
LT(_, KC_MS_BTN_3)perhaps. However in practice that does not feel great due to the latency between key press and registering the layer change to allow scroll. The deadzone approach feels much more responsive.testing
I'm the only person who has tested/used this specific impl. But it's very simple and I've been dailying on my adept for around half a year. I find it very comfortable to use and it generally succeeds in saving me a button.
Unsure if this is useful to anybody not using the adept, but hopefully there's value in this.