Skip to content

Fix stack overflow when circular callbacks are displayed on the devtool callback #3490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix stack overflow when circular callbacks are displayed on the devtool callback #3490

wants to merge 1 commit into from

Conversation

@Aaron-Wrote-This
Copy link

@Aaron-Wrote-This Aaron-Wrote-This commented Oct 30, 2025

Fixes stack overflow seen when accessing the Callback Graph when there are circular callbacks present.
Solves: #1656

image

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • Add cycle breaker to CallbackGraphEffects updateSelectedNode
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

@Aaron-Wrote-This Aaron-Wrote-This force-pushed the bugfix/callback_graph_recursion_on_circular_dependencies branch from 6672da7 to 8c748b1 Compare November 1, 2025 04:28
@Aaron-Wrote-This Aaron-Wrote-This force-pushed the bugfix/callback_graph_recursion_on_circular_dependencies branch from 8c748b1 to fd083aa Compare November 4, 2025 02:18
T4rk1n
T4rk1n reviewed Nov 4, 2025
View reviewed changes
Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to run npm run format to fix the linting issue.

dash/dash-renderer/src/components/error/CallbackGraph/CallbackGraphEffects.js
Comment on lines +30 to +32
function ascend(node, collection, visited = new Set()) {
// FIXME: Should we include State parents but non-recursively?
if (visited.has(node.id())) {
Copy link
Contributor

@T4rk1n T4rk1n Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove that fixme comment now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T4rk1n T4rk1n T4rk1n left review comments

@ndrezn ndrezn Awaiting requested review from ndrezn ndrezn is a code owner

@emilykl emilykl Awaiting requested review from emilykl emilykl is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Aaron-Wrote-This @T4rk1n