Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Turkish locale #7352

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Update Turkish locale #7352

merged 2 commits into from
Feb 6, 2025

Conversation

orhansonmeztr
Copy link
Contributor

Due to @gvwilson's comment on the issue Turkish localization for numbers #7336

@gvwilson
Copy link
Contributor

gvwilson commented Feb 3, 2025

Thanks very much @orhansonmeztr - I'll try to find someone who can review this as soon as possible.

@gvwilson gvwilson self-assigned this Feb 3, 2025
@gvwilson gvwilson added feature something new community community contribution P1 needed for current cycle labels Feb 3, 2025
Copy link

@atasayginodabasi atasayginodabasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization looks good to me. Specially decimal and thousands separator additions are really valuable.

'Download plot as a png': 'Grafiği PNG olarak indir',
'Download plot': 'Grafiği indir',
'Edit in Chart Studio': "Chart Studio'da düzenle",
'IE only supports svg. Changing format to svg.': "IE yalnızca svg'yi destekliyor. Format svg olarak değiştiriliyor.",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"IE yalnızca svg'yi destekler. Format svg'ye dönüştürülüyor" ifadesi daha açık olabilir

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orhansonmeztr can you please check this and let us know if you agree? thanks - and thanks @atasayginodabasi for the quick review

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gvwilson yes, the suggested expression is more appropriate.
thanks @atasayginodabasi for the review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orhansonmeztr @gvwilson thanks all. it was a pleasure

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks both - @orhansonmeztr please update your branch and push once again to include this change, and then I'll go ahead and merge - cheers

update the file as suggested by @atasayginodabasi
@gvwilson gvwilson merged commit 191a14f into plotly:master Feb 6, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution feature something new P1 needed for current cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants