-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Turkish locale #7352
Update Turkish locale #7352
Conversation
Thanks very much @orhansonmeztr - I'll try to find someone who can review this as soon as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Localization looks good to me. Specially decimal and thousands separator additions are really valuable.
lib/locales/tr.js
Outdated
'Download plot as a png': 'Grafiği PNG olarak indir', | ||
'Download plot': 'Grafiği indir', | ||
'Edit in Chart Studio': "Chart Studio'da düzenle", | ||
'IE only supports svg. Changing format to svg.': "IE yalnızca svg'yi destekliyor. Format svg olarak değiştiriliyor.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"IE yalnızca svg'yi destekler. Format svg'ye dönüştürülüyor" ifadesi daha açık olabilir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orhansonmeztr can you please check this and let us know if you agree? thanks - and thanks @atasayginodabasi for the quick review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gvwilson yes, the suggested expression is more appropriate.
thanks @atasayginodabasi for the review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orhansonmeztr @gvwilson thanks all. it was a pleasure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks both - @orhansonmeztr please update your branch and push once again to include this change, and then I'll go ahead and merge - cheers
update the file as suggested by @atasayginodabasi
Due to @gvwilson's comment on the issue Turkish localization for numbers #7336