Skip to content

Conversation

@mernst
Copy link
Contributor

@mernst mernst commented Oct 12, 2025

Summary by CodeRabbit

  • Chores
    • Updated continuous integration test matrix to focus on supported Java versions (17, 21, 25), dropping deprecated/early-access variants to streamline builds.
    • No changes to build steps or application behavior.
    • Improves reliability and consistency of CI runs with clearer version targeting.
    • No impact on features, user workflows, or public APIs; release functionality remains unchanged.

@coderabbitai
Copy link

coderabbitai bot commented Oct 12, 2025

📝 Walkthrough

Walkthrough

The CI workflow matrix in .github/workflows/gradle.yml was updated to remove Java 24 and 25-ea, retaining Java 17, 21, and 25. No other steps, jobs, or logic were changed.

Changes

Cohort / File(s) Summary of Changes
CI workflow matrix update
\.github/workflows/gradle.yml
Adjusted Java versions in the build matrix: removed 24 and 25-ea; kept 17, 21, and 25. No other workflow modifications.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title “Test under JDK 25” accurately and concisely summarizes the main change of updating the CI workflow to include JDK 25 testing, clearly reflecting the core intent without unnecessary detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 238eb11 and d102a86.

📒 Files selected for processing (1)
  • .github/workflows/gradle.yml (1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/gradle.yml

[error] 12-12: too many spaces inside brackets

(brackets)


[error] 12-12: too many spaces inside brackets

(brackets)

strategy:
matrix:
java: [ '17', '21', '24', '25-ea' ]
java: [ '17', '21', '25' ]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion | 🟠 Major

Fix YAMLlint error on matrix list spacing

YAMLlint flags Line 12 (“too many spaces inside brackets”), which will fail linting. Drop the inner padding so the matrix passes lint.

-        java: [ '17', '21', '25' ]
+        java: ['17', '21', '25']
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
java: [ '17', '21', '25' ]
java: ['17', '21', '25']
🧰 Tools
🪛 YAMLlint (1.37.1)

[error] 12-12: too many spaces inside brackets

(brackets)


[error] 12-12: too many spaces inside brackets

(brackets)

🤖 Prompt for AI Agents
.github/workflows/gradle.yml around line 12: the matrix entry currently uses
spaced brackets ("java: [ '17', '21', '25' ]") which YAMLlint flags for "too
many spaces inside brackets"; remove the inner padding so the list has no spaces
inside the brackets (e.g. "java:['17','21','25']") or convert to a standard YAML
sequence (each version on its own line) to satisfy linting.

@mernst mernst closed this Oct 12, 2025
@mernst mernst deleted the java-25-released branch October 12, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant