-
Notifications
You must be signed in to change notification settings - Fork 8
Use double quotes in Gradle files #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThis pull request standardizes string quoting in Gradle build files: single-quoted literals were converted to double-quoted literals across Pre-merge checks and finishing touches✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
build.gradle(6 hunks)gradle/mavencentral.gradle(4 hunks)
🔇 Additional comments (11)
build.gradle (8)
2-15: Approved: Plugin and version strings standardized to double quotes.Quote conversions for plugin declarations are straightforward and functionally equivalent in Groovy/Gradle.
21-21: Approved: Repository URL standardized to double quotes.
26-26: Approved: Extension variable value standardized to double quotes.
46-47: Approved: JUnit engine configuration strings standardized to double quotes.
59-82: Approved: Spotless configuration strings standardized to double quotes.Format names, target file patterns, and formatter versions are consistently converted.
92-101: Approved: Error Prone compiler arguments and options standardized to double quotes.
105-140: Approved: Checker Framework plugin ID, checker class names, and Javac arguments standardized to double quotes.Quote conversions maintain functional equivalence; Groovy/Gradle treat both quote styles identically for regular strings.
157-215: Approved: Javadoc task strings, requireJavadoc task configuration, and JVM export arguments standardized to double quotes.Task descriptions, option strings, and JVM module export arguments are consistently converted.
gradle/mavencentral.gradle (3)
20-26: Approved: Plugin IDs, group, version, and packageName standardized to double quotes.
29-29: Approved: Snapshot version detection string standardized to double quotes.
46-82: Approved: POM metadata, license information, developer details, repository URLs, and credentials keys standardized to double quotes.Quote conversions maintain functional equivalence. Property access methods (
.get(),.getOrDefault()) remain unchanged.
No description provided.