Better definition of requireJavadoc task

[mernst]

No description provided.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request modifies the build.gradle file to update Java compilation and documentation task configurations. For Java 21 and higher, the lint compiler arguments are expanded to include -Xlint:all,-processing,-options,-this-escape from the previous -processing,-options setting. The requireJavadoc task is refactored from direct task registration to variable assignment and its inputs are changed from jar.getArchiveFile() to sourceSets.main.allJava, with arguments updated to use dynamic absolute paths from source directories. An unused debugging flag is also removed from compiler arguments.

Pre-merge checks and finishing touches

✅ Passed checks (1 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b4af29e and 1737b8d.

📒 Files selected for processing (1)

• build.gradle (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: build (17)
• GitHub Check: build (21)
• GitHub Check: build (25)

🔇 Additional comments (4)

build.gradle (4)

107-112: LGTM! Clear handling of version-specific lint warnings.

The updated comment clarifies the reason for disabling -options, and the conditional logic appropriately disables -this-escape for Java 21+ while maintaining backward compatibility.

---

250-250: LGTM! Clean refactor of task registration.

The variable assignment pattern is appropriate and works correctly with the dependsOn() calls on lines 268-269.

---

253-253: LGTM! More accurate task inputs.

Changing from jar.getArchiveFile() to sourceSets.main.allJava correctly reflects that this task processes source files, improving incremental build behavior.

---

256-256: No action required—the code change is correct.

RequireJavadoc accepts "[directory-or-file ...]" arguments, and the tool includes a --relative=<boolean> option, indicating it handles both relative and absolute paths. The change from hardcoded "src/main/java" to dynamic sourceSets.main.allJava.srcDirs.collect{it.getAbsolutePath()} is appropriate and will work correctly.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}