Skip to content

[WIP] Performance enhancements #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Performance enhancements #2

wants to merge 1 commit into from

Conversation

alex-sc
Copy link

@alex-sc alex-sc commented Apr 19, 2025

Extracted from plurimath/plurimath#347:

  • lookahead optimization which costs less than entering the actual backtracking
  • Group lookahead optimization for huge alternatives
  • Truncate error_msg

@alex-sc
[WIP] Performance enhancements
13217e7 
Extracted from plurimath/plurimath#347:
- lookahead optimization which costs less than entering the actual backtracking
- Group lookahead optimization for huge alternatives
- Truncate error_msg
@alex-sc
Copy link
Author

alex-sc commented Apr 19, 2025

@ronaldtse A few questions:

  1. Mainstream GHA is disabled on this fork. Could we enable it?
  2. Many Parslet tests rely on parsing 'error' messages which are being truncated/altered in this PR for performance reason. What would be an appropriate way to detect we're running in GHA to keep them as is, but alter in 'production'.

@alex-sc alex-sc mentioned this pull request Apr 19, 2025
Closed
@alex-sc
Copy link
Author

alex-sc commented Apr 24, 2025

@ronaldtse Could you check the above questions? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alex-sc