Use github actions

.github/workflows/lint-test.yaml

@@ -0,0 +1,40 @@
+name: Lint and Test
+
+on: push
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+      - name: Setup Go
+        uses: actions/setup-go@v5
+        with:
+          go-version: "1.21.x"
+      - name: Install dependencies
+        run: go get .
+      - name: Install linters
+        run: |
+          go install honnef.co/go/tools/cmd/staticcheck@latest
+          go install mvdan.cc/unparam@latest
+      - name: go vet
+        run: go vet ${{ inputs.path }}
+      - name: staticcheck
+        run: staticcheck ${{ inputs.path }}
+      - name: unparam
+        run: unparam ${{ inputs.path }}
+
+  test:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+      - name: Setup Go
+        uses: actions/setup-go@v5
+        with:
+          go-version: "1.21.x"
+      - name: Install dependencies
+        run: go get .
+      - name: Run Tests
+        run: go test -v -race ./...

README.md

@@ -1,6 +1,4 @@
-[![Go Report Card](https://goreportcard.com/badge/plutov/paypal)](https://goreportcard.com/report/plutov/paypal)
-[![Build Status](https://travis-ci.org/plutov/paypal.svg?branch=master)](https://travis-ci.org/plutov/paypal)
-[![Godoc](http://img.shields.io/badge/godoc-reference-blue.svg?style=flat)](https://godoc.org/github.com/plutov/paypal)
+[Docs](https://pkg.go.dev/github.com/plutov/paypal)
 
 # Go client for PayPal REST API
 

client_test.go

@@ -13,17 +13,6 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
-// testClientID, testSecret imported from order_test.go
-
-// All test values are defined here
-// var testClientID = "AXy9orp-CDaHhBZ9C78QHW2BKZpACgroqo85_NIOa9mIfJ9QnSVKzY-X_rivR_fTUUr6aLjcJsj6sDur"
-// var testSecret = "EBoIiUSkCKeSk49hHSgTem1qnjzzJgRQHDEHvGpzlLEf_nIoJd91xu8rPOBDCdR_UYNKVxJE-UgS2iCw"
-var testUserID = "https://www.paypal.com/webapps/auth/identity/user/VBqgHcgZwb1PBs69ybjjXfIW86_Hr93aBvF_Rgbh2II"
-var testCardID = "CARD-54E6956910402550WKGRL6EA"
-
-var testProductId = ""   // will be fetched in  func TestProduct(t *testing.T)
-var testBillingPlan = "" // will be fetched in  func TestSubscriptionPlans(t *testing.T)
-
 const alphabet = "abcedfghijklmnopqrstuvwxyz"
 
 func RandomString(n int) string {
@@ -106,17 +95,6 @@ func TestClientMutex(t *testing.T) {
 	c, _ := NewClient(testClientID, testSecret, APIBaseSandBox)
 	c.GetAccessToken(context.Background())
 
-	// Basic Testing of the private mutex field
-	c.mu.Lock()
-	if c.mu.TryLock() {
-		t.Fatalf("TryLock succeeded with mutex locked")
-	}
-	c.mu.Unlock()
-	if !c.mu.TryLock() {
-		t.Fatalf("TryLock failed with mutex unlocked")
-	}
-	c.mu.Unlock() // undo changes from the previous TryLock
-
 	// Operational testing of the private mutex field
 	n_iter := 2
 

products.go

@@ -33,27 +33,27 @@ type (
 	}
 )
 
-func (self *Product) GetUpdatePatch() []Patch {
+func (p *Product) GetUpdatePatch() []Patch {
 	return []Patch{
 		{
 			Operation: "replace",
 			Path:      "/description",
-			Value:     self.Description,
+			Value:     p.Description,
 		},
 		{
 			Operation: "replace",
 			Path:      "/category",
-			Value:     self.Category,
+			Value:     p.Category,
 		},
 		{
 			Operation: "replace",
 			Path:      "/image_url",
-			Value:     self.ImageUrl,
+			Value:     p.ImageUrl,
 		},
 		{
 			Operation: "replace",
 			Path:      "/home_url",
-			Value:     self.HomeUrl,
+			Value:     p.HomeUrl,
 		},
 	}
 }

subscription.go

@@ -77,7 +77,7 @@ type (
 
 	// https://developer.paypal.com/docs/api/subscriptions/v1/#definition-plan_override
 	PlanOverride struct {
-		BillingCycles      []BillingCycleOverride       `json:"billing_cycles,omitempty"`
+		BillingCycles      []BillingCycleOverride      `json:"billing_cycles,omitempty"`
 		PaymentPreferences *PaymentPreferencesOverride `json:"payment_preferences,omitempty"`
 		Taxes              *TaxesOverride              `json:"taxes,omitempty"`
 	}
@@ -104,12 +104,12 @@ type (
 	}
 )
 
-func (self *Subscription) GetUpdatePatch() []Patch {
+func (p *Subscription) GetUpdatePatch() []Patch {
 	result := []Patch{
 		{
 			Operation: "replace",
 			Path:      "/billing_info/outstanding_balance",
-			Value:     self.BillingInfo.OutstandingBalance,
+			Value:     p.BillingInfo.OutstandingBalance,
 		},
 	}
 	return result

subscription_plan.go

@@ -82,47 +82,47 @@ type (
 	}
 )
 
-func (self *SubscriptionPlan) GetUpdatePatch() []Patch {
+func (p *SubscriptionPlan) GetUpdatePatch() []Patch {
 	result := []Patch{
 		{
 			Operation: "replace",
 			Path:      "/description",
-			Value:     self.Description,
+			Value:     p.Description,
 		},
 	}
 
-	if self.Taxes != nil {
+	if p.Taxes != nil {
 		result = append(result, Patch{
 			Operation: "replace",
 			Path:      "/taxes/percentage",
-			Value:     self.Taxes.Percentage,
+			Value:     p.Taxes.Percentage,
 		})
 	}
 
-	if self.PaymentPreferences != nil {
-		if self.PaymentPreferences.SetupFee != nil {
+	if p.PaymentPreferences != nil {
+		if p.PaymentPreferences.SetupFee != nil {
 			result = append(result, Patch{
 				Operation: "replace",
 				Path:      "/payment_preferences/setup_fee",
-				Value:     self.PaymentPreferences.SetupFee,
+				Value:     p.PaymentPreferences.SetupFee,
 			},
 			)
 		}
 
 		result = append(result, []Patch{{
 			Operation: "replace",
 			Path:      "/payment_preferences/auto_bill_outstanding",
-			Value:     self.PaymentPreferences.AutoBillOutstanding,
+			Value:     p.PaymentPreferences.AutoBillOutstanding,
 		},
 			{
 				Operation: "replace",
 				Path:      "/payment_preferences/payment_failure_threshold",
-				Value:     self.PaymentPreferences.PaymentFailureThreshold,
+				Value:     p.PaymentPreferences.PaymentFailureThreshold,
 			},
 			{
 				Operation: "replace",
 				Path:      "/payment_preferences/setup_fee_failure_action",
-				Value:     self.PaymentPreferences.SetupFeeFailureAction,
+				Value:     p.PaymentPreferences.SetupFeeFailureAction,
 			}}...)
 	}