Skip to content

Adds sample data in EPT format #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adds sample data in EPT format #17

wants to merge 2 commits into from

Conversation

iosefa
Copy link

@iosefa iosefa commented Aug 4, 2018

This PR adds sample data in the EPT format.

The sample dataset was originally prepared by Markus Neteler and Helena Mitasova in their book "Open Source GIS: A GRASS GIS Approach". It has been converted to the EPT format for testing purposes.

@dkastl
Copy link
Contributor

dkastl commented Aug 6, 2018

@iosefa , is this NorthCarolina data from GRASS workshop?

@iosefa
Copy link
Author

iosefa commented Aug 6, 2018

@dkastl , yes it is

Copy link
Contributor

@dkastl dkastl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we don't change this data too often, it should not increase the size of the repository too

@martinheidegger
Copy link
Contributor

martinheidegger commented Aug 7, 2018

Thank you for the PR ... oh so many files 😅 . After reading your kind documentation

The following dataset may be used for visualization and testing purposes.

... I was wondering if we should place the data in a own repository (That is published on npm). In order for the data to be only downloaded for development purposes and not keep historic data. Would you be okay with that? @pnext/admin

The data itself is looks good with lots of edges that allow for good tests. What i noticed: I wish there also was binary data version to test the other way data could be stored (also its quicker to implement).

@martinheidegger
Copy link
Contributor

Ping @iosefa

@iosefa
Copy link
Author

iosefa commented Aug 17, 2018

@martinheidegger, Aren't .las and .laz binary file formats? Or was there another specific file format that you were thinking of? Re. a published repository on npm, I can get to this next week 😄

@martinheidegger
Copy link
Contributor

Yes, .las and .laz are binary file formats; but EPT supports custom binary data: https://github.com/connormanning/ept#datatype

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants