Fix: PointCloud pick with an Orthographic camera does not use mouse position #183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PointCloudPicker.pick
does not work for Orthographic cameras.Typically when raycasting, the picking ray is generated using the ThreeJS method
raycaster.setFromCamera(coords, camera)
. When this method is called with an Orthographic camera, the ray.direction will be the camera direction, and the ray.origin will be based on where the mouse is on the screen.This is where the issue comes up. When calculating the pixelPosition in the
pick
method, we use the camera.position and then ray.direction. Therefore, regardless of where the mouse is on the screen, and Orthographic ray will always be projected from the center of the camera.The solution here is to use the ray.origin instead of the camera.position to build the correct vector and then project it into camera space.