feat: support Potree1 LAS / LAZ formats #192
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jordan-Lane
changed the title
|
Addresses this issue: #61 |
|
Unfortunately, attempting to import laz-perf during the typescript build step requires a huge amount of memory to be able to build it. I didn't notice this locally, but it immediately blew up in CircleCI. I will close this PR and open a new PR with a JS worker with laz-perf inline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to support the LAS / LAZ format for Potree1 pointclouds. Code is adapted from the original Potree repo, but has been changed to follow the coding standards of this repo.
This PR is dependent on the shared worker pool PR found here: #182
This PR looks massive because it adds the static file laz-perf.js which is from this npm package and it is how the original Potree loaded LAZ files. It would be best to install this package through npm, however to do that we will need to update the worker-pool to create Workers using the standard URL notation, which allows npm modules to be imported with the correct URL path. If this is desired, I can upgrade the worker-pool and create the related PR.