Multiple cameras and renderers per single scene #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 26, 2019 10:36
hccampos
requested changes
Nov 28, 2019
src/potree.ts
Outdated
| camera: Camera, | ||
| renderer: WebGLRenderer, | ||
| cameras: Camera[], | ||
| renderers: WebGLRenderer[], |
There was a problem hiding this comment.
Imho, this should be kept backwards-compatible. We could do something like
cameras = Array.isArray(cameras) ? cameras : [cameras];There was a problem hiding this comment.
The typing could also be set to
OrthographicCamera | PerspectiveCamera | OrthographicCamera[] | PerspectiveCamera[]
src/potree.ts
Outdated
| priorityQueue: BinaryHeap<QueueItem>; | ||
| } => { | ||
| const frustums: Frustum[] = []; | ||
| const cameraPositions = []; | ||
| const frustums: Frustum[][] = []; |
There was a problem hiding this comment.
I am a bit worried about the garbage due to creating all these arrays each frame.
|
Sorry I typically have prettier fire automatically on commit so I might have left some badly formatted or semicolon-less lines in there |
|
housekeeping: closing the PR as there are no recent updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've put together a fairly quick and primitive implementation of re-using the same point cloud scene in multiple WebGL contexts. Without this change, you have to designate a "key camera" that will determine the point load/unload and the other camera(s) just has to live with what it gets. I took the stance that all passed cameras need to be of the same type for simplicity sake but this could be accounted for. Also that cameras and renderers are 1:1 since that fits my use case. Not sure if this is too different and should be kept as a fork or not so I didn't polish it much
Some things that would need to be improved still are the
updateMaterialfunction that's looking for perspective frustum params, plucking theminDistanceandmaxScreenPixelRadiusefficiently, making a real example, and cleaning up function arguments.