Merged
Conversation
Collaborator
Author
|
It will be merged after approval from any reviewer. |
RyanZurrin
suggested changes
Apr 7, 2025
Contributor
RyanZurrin
left a comment
RyanZurrin
left a comment
There was a problem hiding this comment.
Change Slicer 4 to Slicer 5 on line 98 in the README.md.
README.md
Outdated
| * It may be helpful to [test the exension upload](https://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/Build_ExtensionsIndex#Extension_build.2C_test.2C_package_and_upload_using_.60ExperimentalUpload.60_target) using your API key. | ||
|
|
||
| ### 2. As a Slicer 4 Extension | ||
| ### 3. As a Slicer 4 Extension |
Contributor
There was a problem hiding this comment.
Hi Tashrif, do you think we should update the 4 to a 5 for the version of Slicer the extension is available for?
Collaborator
Author
There was a problem hiding this comment.
It should be removed entirely. We built this as an extension last time in 2018. No one has tried it after that.
Collaborator
Author
There was a problem hiding this comment.
@RyanZurrin , please review PR #175 that addresses your comment.
The build instructions have not been tried against Slicer 5
Collaborator
Author
|
I just checked that the extension files are still suffixed |
Closed
Address Ryan's suggestion about updating Slicer version in README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.