Skip to content

Conversation

@btea
Copy link
Member

@btea btea commented Oct 27, 2025

No description provided.

@alexbit-codemod
Copy link
Collaborator

@btea Thank you for the contribution, but I noticed you have used the legacy/deprecated Codemod toolkit/workflow engine. May I ask how that happened? (I want to make sure we don't have deprecated docs or links that encourage people to use that.)

We have a much better toolkit now, and you can find the docs here: https://docs.codemod.com/cli/cli-reference

Given you have fresh context for this codemod, would you be able to recreate it in the new system? Sorry about that.

If you need help, feel free to ping me in the Codemod community to quickly answer your questions if you get blocked on something.

Copy link
Collaborator

@alexbit-codemod alexbit-codemod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use Codemod's latest toolkit.

@btea
Copy link
Member Author

btea commented Nov 14, 2025

@alexbit-codemod Thank you for your review. I'm not familiar with Codemod, I simply added functionality based on existing repository code.

I will modify it according to the documentation you provided as soon as possible. Thank you for your guidance.

@alexbit-codemod
Copy link
Collaborator

thank you so much for your flexibility and understanding. so looking forward to your contribution. and again, if you have any questions, feel free to ping me on slack: https://go.codemod.com/community

@zkochan zkochan requested a review from Copilot November 21, 2025 14:35
Copilot finished reviewing on behalf of zkochan November 21, 2025 14:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new codemod to migrate patch files from patch-package format to pnpm's native patch format. The codemod converts patch filenames, removes node_modules/ prefixes from patch content, and updates configuration files (package.json and pnpm-workspace.yaml) accordingly.

Key Changes

  • New patch workspace package with complete codemod implementation including transformers, scanners, and utilities
  • Workspace configuration updates to include the new patch package
  • Automated migration workflow that handles .patch files, package.json, and pnpm-workspace.yaml

Reviewed changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
pnpm-workspace.yaml Added patch to workspace packages
pnpm-lock.yaml Added dependencies for the patch codemod package
patch/workflow.yaml Defines the transformation workflow for converting patches
patch/tsconfig.json TypeScript configuration for the codemod
patch/package.json Package definition with scripts and dependencies
patch/codemod.yaml Codemod metadata and configuration
patch/README.md Documentation for using the codemod
patch/LICENSE MIT license for the codemod
patch/.gitignore Ignore patterns for the package
patch/src/codemod.ts Main entry point that routes files to appropriate transformers
patch/src/types.ts TypeScript type definitions for the codemod
patch/src/constants.ts Constants for file patterns and separators
patch/src/utils/path.ts Path normalization and workspace detection utilities
patch/src/utils/patch-filename.ts Filename conversion utilities for patch files
patch/src/utils/errors.ts Error detection helpers
patch/src/transforms/patch-file.ts Transforms patch file content and filenames
patch/src/transforms/package-json.ts Updates package.json with patched dependencies
patch/src/transforms/workspace-yaml.ts Updates pnpm-workspace.yaml configuration
patch/src/scanners/patch-scanner.ts Scans and identifies patch files in the workspace
package.json Added convenience script to run the patch codemod
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@btea btea requested a review from Copilot November 22, 2025 07:53
Copilot finished reviewing on behalf of btea November 22, 2025 07:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 20 changed files in this pull request and generated 14 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zkochan zkochan merged commit d398262 into main Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants