Skip to content

Add ARD Sounds app detection - #29

Merged
spiderpug merged 2 commits into
masterfrom
ivan/add-ard-sounds-user-agent
Mar 31, 2026
Merged

Add ARD Sounds app detection#29
spiderpug merged 2 commits into
masterfrom
ivan/add-ard-sounds-user-agent

Conversation

@axenoff

@axenoff axenoff commented Mar 27, 2026

Copy link
Copy Markdown

Summary

  • Add "ARD Sounds" as a recognized podcast app, replacing "ARD Audiothek" which was rebranded on March 9th
  • Matches user agents starting with ARD Sounds, ARD%20Sounds, and ARD-Sounds with iOS/Android/Darwin platform detection
  • Prevents ARD Sounds traffic from being misattributed as "Android Browser"
  • Bump gem version to 1.1.10

Test plan

  • All 838 RSpec tests pass, including 4 new ARD Sounds test cases (Android, iOS, Darwin/CFNetwork, short format)

Summary by CodeRabbit

  • New Features

    • Added detection support for the ARD Sounds app with platform normalization for iOS/Android/Darwin.
  • Tests

    • Extended and updated detection test cases, including ARD Sounds and adjusted HermesPod test data.
  • Chores

    • Version bumped to 1.1.10 and changelog updated.

@coderabbitai

coderabbitai Bot commented Mar 27, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: eb351215-4a6a-4db9-b2ac-8152fb067afd

📥 Commits

Reviewing files that changed from the base of the PR and between 67c4c70 and 7b0f4d1.

📒 Files selected for processing (3)
  • lib/detection_rules.yml
  • lib/pod_ident/detection_rules.rb
  • spec/detection_rules.rb
🚧 Files skipped from review as they are similar to previous changes (3)
  • spec/detection_rules.rb
  • lib/detection_rules.yml
  • lib/pod_ident/detection_rules.rb

📝 Walkthrough

Walkthrough

Adds detection for the ARD Sounds app (adds new matching variants and platform normalization), bumps version to 1.1.10, and updates detection test fixtures (including a HermesPod rule tweak).

Changes

Cohort / File(s) Summary
Version Bump & Changelog
lib/pod_ident/version.rb, CHANGELOG.md
Version updated from 1.1.91.1.10; changelog entry added noting ARD Sounds detection.
ARD Sounds Detection Rules
lib/detection_rules.yml, lib/pod_ident/detection_rules.rb
Added/updated rule for app ARD Sounds with match.startsWith expanded to ["ARD Sounds","ARD%20Sounds","ARD-Sounds","ARD Audiothek"]; platform.regex broadened to `"(iOS
Test Fixtures
spec/detection_rules.rb
Regenerated RULES constant; HermesPod rule startsWith and test userAgent updated to include +hermespod.com prefix; file newline state normalized.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🎧 New sounds arrive with version light,
ARD listens in both day and night,
Platforms smoothed and tests run through,
A tidy bump to one-one-ten too —
Cheers to clearer detection, bright! 🎶

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding detection for the ARD Sounds podcast app, which is the primary focus of all file modifications across the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ivan/add-ard-sounds-user-agent

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 RuboCop (1.86.0)
spec/detection_rules.rb

Error: The Metrics/LineLength cop has been moved to Layout/LineLength.
(obsolete configuration found in .rubocop.yml, please update it)

lib/pod_ident/detection_rules.rb

Error: The Metrics/LineLength cop has been moved to Layout/LineLength.
(obsolete configuration found in .rubocop.yml, please update it)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@lib/detection_rules.yml`:
- Around line 1103-1124: The repo now contains two canonical labels for the same
app — the new rule with app: ARD Sounds and the older rule that still emits app:
ARD Audiothek — which fragments analytics; update the earlier rule that emits
"ARD Audiothek" to use the canonical label "ARD Sounds" (or merge the two rules)
and ensure its match patterns and test userAgents are preserved/merged into the
ARD Sounds rule so all detection cases map to the single canonical identifier
(check the rules that reference "ARD Audiothek" and consolidate their
match/startsWith entries, platform replacements, and test entries into the ARD
Sounds rule).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8db8b88e-8970-46b3-9145-56382257a946

📥 Commits

Reviewing files that changed from the base of the PR and between f0d5c2c and 67c4c70.

⛔ Files ignored due to path filters (1)
  • Gemfile.lock is excluded by !**/*.lock
📒 Files selected for processing (5)
  • CHANGELOG.md
  • lib/detection_rules.yml
  • lib/pod_ident/detection_rules.rb
  • lib/pod_ident/version.rb
  • spec/detection_rules.rb

Comment thread lib/detection_rules.yml
@spiderpug
spiderpug merged commit 7568417 into master Mar 31, 2026
2 checks passed
@spiderpug
spiderpug deleted the ivan/add-ard-sounds-user-agent branch March 31, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants