various small fixes and some package cleanup#25
Merged
Conversation
podman 6 hard errors if it detects no cgroupv2 mount. To make it happy we need to ensure we have it mounted. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
There was a problem with the podman pull retries which cause the stderr to be hidden making it much harder to debug the failure cause. New podman and skopeo versions have build in retries for network and registry errors. Use that so it does not retry on unrelated errors, i.e. image not found. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Remove the must_pass function, the only last caller already calls it under the set -e context. The set -e also says only for the next few commands but this is never unset. To ensure all commands handle errors right just do set -e once globally which is a lot simpler. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
We do not use this command. We also should not install it as part of the container image as it pulls in grub and really makes no sense in this context. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
We no longer support cni or slirp4netns or iptables. So lets remove the packages to slim down the images a bit. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Member
Author
|
@ashley-cui PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see commits