fix: update packit failure-notification team to new org#29070
Conversation
The Packit failure-notification message tagged @containers/packit-build, a team under the old containers org that no longer resolves after the repo moved to podman-container-tools. Point the mention at @podman-container-tools/packit-build so maintainers are pinged on Packit job failures again. The message is defined once on the &packit_generic_failure_notification YAML anchor (.packit.yaml line 56) and reused by reference on lines 71, 85, and 106, so the single edit covers every job that uses it. Fixes podman-container-tools#28882 Signed-off-by: mvanhorn <mvanhorn@gmail.com>
|
[NON-BLOCKING] Packit jobs failed. @podman-container-tools/packit-build please check. Everyone else, feel free to ignore. |
danishprakash
left a comment
There was a problem hiding this comment.
Afaict, no such team exists so far but even the old team only had @lsm5 so we can create it if needed.
| notifications: &packit_generic_failure_notification | ||
| failure_comment: | ||
| message: "[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore." | ||
| message: "[NON-BLOCKING] Packit jobs failed. @podman-container-tools/packit-build please check. Everyone else, feel free to ignore." |
There was a problem hiding this comment.
This group doesn't exist. The question is whether we want to tag someone or not. cc @lsm5
|
@mvanhorn you already have two open PRs where you do not respond to any review feedback, if you are unable to engage in code review and make changes than please do not open further PRs until your existing PRs are done, either by merging or closing. Otherwise this just wastes our time. |
The Packit failure-notification comment in
.packit.yamltagged@containers/packit-build, a team under the oldcontainersorg that no longer resolves now that the repo lives inpodman-container-tools. As a result the mention is dead and maintainers are not pinged when Packit jobs fail.This points the mention at
@podman-container-tools/packit-build. The message is defined once on the&packit_generic_failure_notificationYAML anchor (.packit.yamlline 56) and reused by reference on lines 71, 85, and 106, so the single edit covers every job that uses it. The individual@-handles on the Cockpit and tmt failure comments are untouched.cc @lsm5 to confirm the exact team slug exists under the new org.
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?
Fixes #28882