Add podman-remote quadlet command#29088
Open
inknos wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
kind/api-change
Contributor
Author
|
@Honny1 here's the new PR for quadlets after the app were added |
Honny1
requested changes
Jun 30, 2026
Honny1
left a comment
Honny1
left a comment
Contributor
There was a problem hiding this comment.
I have some comments and also tried check some causes of failures.
| func (ic *ContainerEngine) QuadletPrint(_ context.Context, _ string) (string, error) { | ||
| return "", errNotImplemented | ||
| func downloadToTemp(fileURL string) (string, error) { | ||
| resp, err := http.Get(fileURL) //nolint:gosec,noctx |
Contributor
There was a problem hiding this comment.
What if that file doesn't exist and it will get a 404 or 500?
Contributor
Author
There was a problem hiding this comment.
right, I will address it
| groups := groupByQuadletFile(allFiles) | ||
|
|
||
| for _, group := range groups { | ||
| installReport, err := quadlets.Install(ic.ClientCtx, group, options) |
Contributor
There was a problem hiding this comment.
Well, is this right? Each call of this will trigger a systemd reload.
Comment on lines
+215
to
+224
| if cd != "" { | ||
| const prefix = "filename=" | ||
| if idx := strings.Index(cd, prefix); idx != -1 { | ||
| filename := cd[idx+len(prefix):] | ||
| filename = strings.Trim(filename, "\"'") | ||
| if filename != "" { | ||
| return filename | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
What about using: mime.ParseMediaType(cd)
| return nil, nil, fmt.Errorf("cannot stat %s: %w", arg, err) | ||
| } | ||
| if info.IsDir() { | ||
| entries, err := os.ReadDir(arg) |
Contributor
There was a problem hiding this comment.
Why not use filepath.WalkDir?
| QuadletErrors: make(map[string]error), | ||
| } | ||
|
|
||
| allFiles, cleanup, err := resolveInstallPaths(pathsOrURLs) |
Contributor
There was a problem hiding this comment.
What if opts.Application is set and pathsOrURLs dir structure?
inknos
force-pushed
the
RUN-4852
branch
2 times, most recently
from
1a0be6f to
8fd8f35
Compare
Contributor
Author
|
addressed comments, pushed, error, rebased, pushed again |
Fixes: https://redhat.atlassian.net/browse/RUN-4852 Signed-off-by: Nicola Sella <nsella@redhat.com>
Honny1
added
the
bloat_approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://redhat.atlassian.net/browse/RUN-4852
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?