add logformatter back and provide better github log output #29091
Open
Luap99 wants to merge 2 commits into
Open
add logformatter back and provide better github log output #29091Luap99 wants to merge 2 commits into
Luap99 wants to merge 2 commits into
Conversation
Luap99
force-pushed
the
logformatter
branch
8 times, most recently
from
715d387 to
1297d16
Compare
Adapt the logformatter script to run again to produce nicely formatted html logs. Because github cannot upload and show raw html files we can only add it to the log archive which must be downloaded and viewed locally. To improve the online experience however github does have the GITHUB_STEP_SUMMARY logic which allows us to produce markdown which will be shown on the summary page for a given test run. The problem is even though github markdown supports some html is does not support CSS and out custom style of the logformatter, in addition the output size is limited so I wrote another script parsing the html output again and turning it into plain test for only the failed tests and then show this as plain text inside codeblocks in the markdown. With this we have a short failure summary which should display all failures at once in the run page so maintainers can see if the failed log was just some flake or an actual problem with the PR. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This groups log output in the github UI and makes it easier to just show the actual test results, the groups are hidden under an extra drop down and only shown when selected. Inspired by Miloslav container-libs change for this. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt the logformatter script to run again to produce nicely formatted
html logs. Because github cannot upload and show raw html files we can
only add it to the log archive which must be downloaded and viewed
locally.
To improve the online experience however github does have the
GITHUB_STEP_SUMMARY logic which allows us to produce markdown which will
be shown on the summary page for a given test run.
The problem is even though github markdown supports some html is does
not support CSS and out custom style of the logformatter, in addition
the output size is limited so I wrote another script parsing the html
output again and turning it into plain test for only the failed tests
and then show this as plain text inside codeblocks in the markdown.
With this we have a short failure summary which should display all
failures at once in the run page so maintainers can see if the failed
log was just some flake or an actual problem with the PR.
Does this PR introduce a user-facing change?