pkg/specgenutilexternal: add tests for FindMountType#29098
Open
ROKUMATE wants to merge 1 commit into
Open
Conversation
00142e5 to
8fd7ac1
Compare
Honny1
reviewed
Jul 7, 2026
Honny1
left a comment
Contributor
There was a problem hiding this comment.
I would like to see also some other cases for example:
type=bind,src=\"/path,with,commas\",target=/bar"(Quoting it could be problematic)type=,target=/bar"(empty key)type = a,target=/bar"(some unexpected white spaces)
Othervise look good.
8fd7ac1 to
c303de3
Compare
Fixes: podman-container-tools#29097 Signed-off-by: ROKUMATE <rohitkumawat0110@gmail.com>
c303de3 to
7c52018
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
added tests for FindMountType parses --mount strings with a table driven coverage for that
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?