Skip to content

pkg/specgenutilexternal: add tests for FindMountType#29098

Open
ROKUMATE wants to merge 1 commit into
podman-container-tools:mainfrom
ROKUMATE:test-pkg-specgenutilexternal
Open

pkg/specgenutilexternal: add tests for FindMountType#29098
ROKUMATE wants to merge 1 commit into
podman-container-tools:mainfrom
ROKUMATE:test-pkg-specgenutilexternal

Conversation

@ROKUMATE

@ROKUMATE ROKUMATE commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

What

added tests for FindMountType parses --mount strings with a table driven coverage for that

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #00000 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

none

@ROKUMATE ROKUMATE force-pushed the test-pkg-specgenutilexternal branch from 00142e5 to 8fd7ac1 Compare July 1, 2026 15:23

@Honny1 Honny1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see also some other cases for example:

  • type=bind,src=\"/path,with,commas\",target=/bar" (Quoting it could be problematic)
  • type=,target=/bar"(empty key)
  • type = a,target=/bar" (some unexpected white spaces)

Othervise look good.

Comment thread pkg/specgenutilexternal/parse_test.go Outdated
@ROKUMATE ROKUMATE force-pushed the test-pkg-specgenutilexternal branch from 8fd7ac1 to c303de3 Compare July 8, 2026 07:03
Fixes: podman-container-tools#29097
Signed-off-by: ROKUMATE <rohitkumawat0110@gmail.com>
@ROKUMATE ROKUMATE force-pushed the test-pkg-specgenutilexternal branch from c303de3 to 7c52018 Compare July 8, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants